Issue 7366004: Fixed: sample shell with shared lib fails to compile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7366004: Fixed: sample shell with shared lib fails to compile. (Closed)

Created:
9 years, 5 months ago by Yang

Modified:
9 years, 5 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

sample shell does not link against shared lib due to latest change Committed: http://code.google.com/p/v8/source/detail?r=8652

Patch Set 1 #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	samples/shell.cc	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Fixed a small bug. http://codereview.chromium.org/7366004/diff/1/samples/shell.cc File samples/shell.cc (right): http://codereview.chromium.org/7366004/diff/1/samples/shell.cc#newcode98 samples/shell.cc:98: #if !(defined(USING_V8_SHARED) || defined(V8_SHARED)) Those ...

9 years, 5 months ago (2011-07-14 09:36:27 UTC) #1

LGTM, thanks

Expand Messages | Collapse Messages