Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 7366002: Fix memory leak from sample/shell.cc. (Closed)

Created:
9 years, 5 months ago by Rico
Modified:
9 years, 5 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Fix memory leak from sample/shell.cc. We did not dispose the semaphores used in SourceGroup Committed: http://code.google.com/p/v8/source/detail?r=8649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M samples/shell.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 5 months ago (2011-07-14 08:24:05 UTC) #1
William Hesse
9 years, 5 months ago (2011-07-14 08:59:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698