Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10353)

Unified Diff: chrome/common/print_messages.h

Issue 7365003: Print Preview: Make preview generation event driven to eliminate synchronous messages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: clang fix Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview_ui.cc ('k') | chrome/renderer/mock_render_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/print_messages.h
===================================================================
--- chrome/common/print_messages.h (revision 92822)
+++ chrome/common/print_messages.h (working copy)
@@ -170,7 +170,12 @@
// Tells a renderer to stop blocking script initiated printing.
IPC_MESSAGE_ROUTED0(PrintMsg_ResetScriptedPrintCount)
+// Tells a renderer to continue generating the print preview.
+IPC_MESSAGE_ROUTED0(PrintMsg_ContinuePreview)
+// Tells a renderer to abort the print preview and reset all state.
+IPC_MESSAGE_ROUTED0(PrintMsg_AbortPreview)
+
// Messages sent from the renderer to the browser.
#if defined(OS_WIN)
@@ -234,19 +239,19 @@
IPC_MESSAGE_ROUTED0(PrintHostMsg_RequestPrintPreview)
// Notify the browser the number of pages in the print preview document.
-IPC_MESSAGE_ROUTED1(PrintHostMsg_DidGetPreviewPageCount,
+IPC_MESSAGE_ROUTED2(PrintHostMsg_DidGetPreviewPageCount,
+ int /* document cookie */,
int /* page count */)
// Notify the browser a print preview page has been rendered. Give the browser
// a chance to cancel the print preview as needed. Page number is zero-based,
// and can be -1 if it is just a check.
-IPC_SYNC_MESSAGE_ROUTED1_1(PrintHostMsg_DidPreviewPage,
- int /* page number */,
- bool /* print preview cancelled */)
+IPC_MESSAGE_ROUTED1(PrintHostMsg_DidPreviewPage,
+ int /* page number */)
-// Sends back to the browser the rendered "printed document" for preview that
-// was requested by a PrintMsg_PrintPreview message. The memory handle in this
-// message is already valid in the browser process.
+// Sends back to the browser the complete rendered document for print preview
+// that was requested by a PrintMsg_PrintPreview message. The memory handle in
+// this message is already valid in the browser process.
IPC_MESSAGE_ROUTED1(PrintHostMsg_PagesReadyForPreview,
PrintHostMsg_DidPreviewDocument_Params /* params */)
@@ -257,7 +262,3 @@
// Tell the browser print preview failed.
IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewFailed,
int /* document cookie */)
-
-// Tell the browser print preview was cancelled.
-IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewCancelled,
- int /* document cookie */)
« no previous file with comments | « chrome/browser/ui/webui/print_preview_ui.cc ('k') | chrome/renderer/mock_render_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698