Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: webkit/plugins/ppapi/plugin_module.cc

Issue 7362012: Remove untrusted scripting support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/thunk/thunk.h ('k') | webkit/plugins/ppapi/ppapi_plugin_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/plugin_module.cc
diff --git a/webkit/plugins/ppapi/plugin_module.cc b/webkit/plugins/ppapi/plugin_module.cc
index 7af6f170891eb7330b4ad3fd1b1f2d371193b310..692ee5a90bddd16001902eb180e8262f1e1ef25f 100644
--- a/webkit/plugins/ppapi/plugin_module.cc
+++ b/webkit/plugins/ppapi/plugin_module.cc
@@ -395,12 +395,6 @@ const void* GetInterface(const char* name) {
if (strcmp(name, PPB_VAR_INTERFACE_0_5) == 0)
return Var::GetInterface();
- // Support the 0.4 version of PPB_Instance that includes scripting, until it
- // is no longer being used.
- // TODO(dmichael): Remove this.
- if (strcmp(name, PPB_INSTANCE_INTERFACE_0_4) == 0)
- return ::ppapi::thunk::GetPPB_Instance_0_4_Thunk();
-
// Support the dev interfaces for file io, fileref and file system
// until relevant tests and examples are migrated over to non-dev interfaces
// in order to prevent breaking the tests and examples.
@@ -561,11 +555,6 @@ PluginInstance* PluginModule::CreateInstance(PluginDelegate* delegate) {
const void* ppp_instance = GetPluginInterface(PPP_INSTANCE_INTERFACE_0_5);
if (ppp_instance) {
instance = PluginInstance::Create0_5(delegate, this, ppp_instance);
- } else {
- // If the 0.5 interface is not supported, try retrieving 0.4.
- ppp_instance = GetPluginInterface(PPP_INSTANCE_INTERFACE_0_4);
- if (ppp_instance)
- instance = PluginInstance::Create0_4(delegate, this, ppp_instance);
}
if (!instance) {
LOG(WARNING) << "Plugin doesn't support instance interface, failing.";
« no previous file with comments | « ppapi/thunk/thunk.h ('k') | webkit/plugins/ppapi/ppapi_plugin_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698