Issue 7358006: Cache OpenGL program info on the client side of the command buffer.

Issue 7358006: Cache OpenGL program info on the client side of the command buffer. (Closed)

Created:
9 years, 5 months ago by greggman

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cache OpenGL program info on the client side of the command buffer. For contexts not sharing resources this means the 3 to 30 calls to get link status and attrib/uniform locations will go from 3-30 sync calls to 1 sync call. TEST=unit tests and ran OpenGL ES 2.0 conformance tests BUG=85966 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95836

Patch Set 1 #

Patch Set 2 : fix warnings #

Total comments: 1

Patch Set 3 : latest #

Patch Set 4 : DCHECK->GPU_DCHECK #

Patch Set 5 : rebase #

Patch Set 6 : fix unit test #

Patch Set 7 : rebase #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+753 lines, -96 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2 3 4 5 6	3 chunks	+13 lines, -9 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.h	View	1 2 3 4 5 6	4 chunks	+14 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.cc	View	1 2 3 4 5 6	11 chunks	+110 lines, -40 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View	1 2 3 4 5 6	6 chunks	+27 lines, -27 lines	0 comments	Download
A	gpu/command_buffer/client/program_info_manager.h	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/program_info_manager.cc	View	1 2 3 4 5 6	1 chunk	+495 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/client/program_info_manager_unittest.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2 3 4 5 6	3 chunks	+5 lines, -13 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/program_manager_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/gpu.gyp	View	1 2 3 4 5 6	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

LGTM with one comment. http://codereview.chromium.org/7358006/diff/2001/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): http://codereview.chromium.org/7358006/diff/2001/gpu/command_buffer/client/gles2_implementation.cc#newcode515 gpu/command_buffer/client/gles2_implementation.cc:515: // program_info_manager_.reset(ProgramInfoManager::Create(sharing_resources_)); delete?

9 years, 5 months ago (2011-07-20 18:28:51 UTC) #2

Change committed as 95836

Expand Messages | Collapse Messages