Print Preview: Refactoring layout mode related logic to LayoutSettings class.

Print Preview: Refactoring layout mode related logic to LayoutSettings class.

BUG=88098
TEST=Layout mode behavior should be unaffected.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92756

[Evan Stade, 2011-07-13 23:42:40]

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:249: var
disableLayoutOption = settingInfo.disableLandscapeOption;
I don't see much point in stashing this into a local var

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:263: disableLayoutOption
? fadeOutElement(layoutSettings.layoutOption) :
layoutSettings.enableLayoutOption(!disableLayoutOption);

fade in/out logic should be hidden

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:760:
fadeOutElement(layoutSettings.layoutOption);
attach PDFLoaded handler in layoutSettings to do this.

[dpapad, 2011-07-14 00:45:15]

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:249: var
disableLayoutOption = settingInfo.disableLandscapeOption;
On 2011/07/13 23:42:40, Evan Stade wrote:
> I don't see much point in stashing this into a local var

Done.

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:263: disableLayoutOption
? fadeOutElement(layoutSettings.layoutOption) :
On 2011/07/13 23:42:40, Evan Stade wrote:
> layoutSettings.enableLayoutOption(!disableLayoutOption);
> 
> fade in/out logic should be hidden

Done.

http://codereview.chromium.org/7358002/diff/1007/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:760:
fadeOutElement(layoutSettings.layoutOption);
On 2011/07/13 23:42:40, Evan Stade wrote:
> attach PDFLoaded handler in layoutSettings to do this.

Done.

[Evan Stade, 2011-07-14 18:51:45]

http://codereview.chromium.org/7358002/diff/7001/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7358002/diff/7001/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:249: function
updateWithPrinterCapabilities(settingInfo) {
could we have a printerCapabilitiesUpdated event similar to PDFLoaded

[dpapad, 2011-07-14 22:17:45]

Added custom event printerCapabilitiesUpdated and also moved more logic out of
print_preview.js.

http://codereview.chromium.org/7358002/diff/7001/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7358002/diff/7001/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:249: function
updateWithPrinterCapabilities(settingInfo) {
On 2011/07/14 18:51:45, Evan Stade wrote:
> could we have a printerCapabilitiesUpdated event similar to PDFLoaded

Done. The remaining statements here will be moved to a listener of that event
once the color options are refactored to a ColorSettings class. Eventually this
function will only fire the event.

[Evan Stade, 2011-07-15 19:47:21]

lgtm

http://codereview.chromium.org/7358002/diff/12002/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/copies_settings.js (right):

http://codereview.chromium.org/7358002/diff/12002/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/copies_settings.js:80: *
remove blank line

http://codereview.chromium.org/7358002/diff/12002/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/layout_settings.js (right):

http://codereview.chromium.org/7358002/diff/12002/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/layout_settings.js:84: onPDFLoaded_:
function() {
comment

[commit-bot: I haz the power, 2011-07-15 21:09:28]

Try job failure for 7358002-22001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...