Linux: Stop installing the gold linker as /usr/bin/ld. Ask users to pass -B/usr/local/gold/bin in...

Linux: Stop installing the gold linker as /usr/bin/ld. Ask users to pass -B/usr/local/gold/bin instead.

Also put ld.bfd next to ld so NaCl builds correctly.

BUG=79769
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100802

[Lei Zhang, 2011-07-13 19:53:08]

The kernel folks are tired of people complaining their kernel does not work
because they build the kernel with gold.

Before I commit this, I need to:
a) fix our build scripts to pass -B/usr/local/gold/bin
b) update all the bots to make sure /usr/local/gold/bin/ld is Gold and not GNU
ld.

And also send out an email to chromium-dev afterwards.

[Evan Martin, 2011-07-13 20:37:37]

LGTM

http://codereview.chromium.org/7355033/diff/4/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/7355033/diff/4/build/install-build-deps.sh#new...
build/install-build-deps.sh:69: # variables.  That will go into
bootstrap-linux.sh when it's ready.
FWIW, there is no bootstrap-linux.sh.

[Evan Martin, 2011-09-07 17:19:21]

http://codereview.chromium.org/7355033/diff/8001/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/7355033/diff/8001/build/install-build-deps.sh#...
build/install-build-deps.sh:72: sudo strip /usr/local/gold/bin/ld
Will this do the right thing if the above tests don't pass?  (I don't quite get
why we test -f above.)

http://codereview.chromium.org/7355033/diff/8001/build/install-build-deps.sh#...
build/install-build-deps.sh:259: echo
Why not offer to restore it here?  I worry that text that follows will obfuscate
this warning.  I think any system that has gold installed like this is almost
certainly a system that was screwed up by us...

[Lei Zhang, 2011-09-08 00:59:25]

See patch set 4.

http://codereview.chromium.org/7355033/diff/8001/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/7355033/diff/8001/build/install-build-deps.sh#...
build/install-build-deps.sh:72: sudo strip /usr/local/gold/bin/ld
On 2011/09/07 17:19:21, Evan Martin wrote:
> Will this do the right thing if the above tests don't pass?  (I don't quite
get
> why we test -f above.)

The line above is slightly wrong, but in any case, we set -e on line one so we
won't get to line 72 if line 71 fails.

But in any case, I did some more configure magic so we don't need line 71.

http://codereview.chromium.org/7355033/diff/8001/build/install-build-deps.sh#...
build/install-build-deps.sh:259: echo
On 2011/09/07 17:19:21, Evan Martin wrote:
> Why not offer to restore it here?  I worry that text that follows will
obfuscate
> this warning.  I think any system that has gold installed like this is almost
> certainly a system that was screwed up by us...

Done.

[Evan Martin, 2011-09-12 19:19:23]

LGTM

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh...
build/install-build-deps.sh:33: --no-restore-urs-bin-ld) 
do_restore_usr_bin_ld=0;;
typo: usr

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh...
build/install-build-deps.sh:266: echo -n "Automatically restore /usr/bin/ld to
the original linker? (Y/n) "
suggestion: s/Automatically r/R/

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh...
build/install-build-deps.sh:277: if [ "$restore_success" = "1" ]
Three lines above can become this, no?

if sudo mv /usr/bin/ld.orig /usr/bin/ld

[Lei Zhang, 2011-09-12 22:00:09]

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh...
build/install-build-deps.sh:33: --no-restore-urs-bin-ld) 
do_restore_usr_bin_ld=0;;
On 2011/09/12 19:19:24, Evan Martin wrote:
> typo: usr

Done.

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh...
build/install-build-deps.sh:266: echo -n "Automatically restore /usr/bin/ld to
the original linker? (Y/n) "
On 2011/09/12 19:19:24, Evan Martin wrote:
> suggestion: s/Automatically r/R/

Done.

http://codereview.chromium.org/7355033/diff/15001/build/install-build-deps.sh...
build/install-build-deps.sh:277: if [ "$restore_success" = "1" ]
On 2011/09/12 19:19:24, Evan Martin wrote:
> Three lines above can become this, no?
> 
> if sudo mv /usr/bin/ld.orig /usr/bin/ld

Done.