Creat BrowsingDataCookieHelper and CannedBrowsingDataCookieHelper for logging cookies at UI thread.

net/base/cookie_monster.cc

Index: net/base/cookie_monster.cc
===================================================================
--- net/base/cookie_monster.cc	(revision 92558)
+++ net/base/cookie_monster.cc	(working copy)
@@ -2098,11 +2098,9 @@
   if (pc.HasDomain()) {
     domain_string = pc.Domain();
   }
-  bool result
-      = GetCookieDomainWithString(url, domain_string,
+  GetCookieDomainWithString(url, domain_string,

[erikwright (departed), 2011/07/19 14:40:33]

What's the background on this change?

[ycxiao1, 2011/07/19 22:12:48]

This canonicalcookie construct was originally used by cookie_info_view.cc and
gtk_chrome_cookie_view.cc. 

This canonicalcookie construct is wanted by
CannedBrowsingDataCookieHelper::AddChangeCookie which loges setcookie. In this
case, the caller can't make sure that the passing arguments are good. It is
normal that SetCookie may fails because of GetCookieDomainWithString failure.
And AddChangeCookie won't log this setcookie if it will fails at persistent
cookie store. This can be implemented by checking the value of domain. The
cookie_domain will equal to "" if and only if GetCookieDomainWithString fails.

                                   &cookie_domain);
   // Caller is responsible for passing in good arguments.
-  DCHECK(result);
   domain_ = cookie_domain;
 }