Creat BrowsingDataCookieHelper and CannedBrowsingDataCookieHelper for logging cookies at UI thread.

net/base/cookie_monster.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Portions of this code based on Mozilla:
 //   (netwerk/cookie/src/nsCookieService.cpp)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
@@ skipping 2080 matching lines @@
     expiry_date_ = CanonExpiration(pc, creation_date_, CookieOptions());
   else
     SetSessionCookieExpiryTime();
 
   // Do the best we can with the domain.
   std::string cookie_domain;
   std::string domain_string;
   if (pc.HasDomain()) {
     domain_string = pc.Domain();
   }
-  bool result
-      = GetCookieDomainWithString(url, domain_string,
+  GetCookieDomainWithString(url, domain_string,

[erikwright (departed), 2011/07/19 14:40:33]

What's the background on this change?

[ycxiao1, 2011/07/19 22:12:48]

This canonicalcookie construct was originally used by cookie_info_view.cc and
gtk_chrome_cookie_view.cc. 

This canonicalcookie construct is wanted by
CannedBrowsingDataCookieHelper::AddChangeCookie which loges setcookie. In this
case, the caller can't make sure that the passing arguments are good. It is
normal that SetCookie may fails because of GetCookieDomainWithString failure.
And AddChangeCookie won't log this setcookie if it will fails at persistent
cookie store. This can be implemented by checking the value of domain. The
cookie_domain will equal to "" if and only if GetCookieDomainWithString fails.

                                   &cookie_domain);
   // Caller is responsible for passing in good arguments.
-  DCHECK(result);
   domain_ = cookie_domain;
 }
 
 CookieMonster::CanonicalCookie::~CanonicalCookie() {
 }
 
 std::string CookieMonster::CanonicalCookie::GetCookieSourceFromURL(
     const GURL& url) {
   if (url.SchemeIsFile())
     return url.spec();
@@ skipping 141 matching lines @@
 std::string CookieMonster::CanonicalCookie::DebugString() const {
   return base::StringPrintf(
       "name: %s value: %s domain: %s path: %s creation: %"
       PRId64,
       name_.c_str(), value_.c_str(),
       domain_.c_str(), path_.c_str(),
       static_cast<int64>(creation_date_.ToTimeT()));
 }
 
 }  // namespace