Lion: Need to use new full-screen API

Lion: Need to use new full-screen API


BUG=74065
TEST=manually. Click full screen button in Lion and see if it goes into fills the screen.

Abandoned. See comments.

[keishi1, 2011-07-13 09:07:31]

Clicking the full screen button sets the window size to fill the screen. The
Chrome full screen mode is completely separate so you can then enter full screen
mode if you want to.

[Mark Mentovai, 2011-07-13 14:46:04]

I don’t think we want to have two separate full-screen modes. Seems really
confusing.

http://codereview.chromium.org/7355016/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/7355016/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.mm:155: // Provide the
forward-declarations of new 10.7 SDK symbols so they can be
10.6, not 10.7.

http://codereview.chromium.org/7355016/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.mm:162: @interface
NSApplication (LionSDKDeclarations)
SnowLeopard, not Lion.

[Robert Sesek, 2011-07-13 14:47:15]

On 2011/07/13 14:46:04, Mark Mentovai wrote:
> I don’t think we want to have two separate full-screen modes. Seems really
> confusing.

While I kind of agree, the Lion folks are getting antsy.

http://codereview.chromium.org/7355016/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

http://codereview.chromium.org/7355016/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.h:332: @interface
BrowserWindowController(LionFullScreen)
nit: space before (

http://codereview.chromium.org/7355016/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.h:333: -
(void)windowDidEnterFullScreen:(NSNotification *)notification;
Chromium style does not put a space between the type and the *

Here and all throughout this CL

[Mark Mentovai, 2011-07-13 14:51:36]

rsesek@chromium.org wrote:
> On 2011/07/13 14:46:04, Mark Mentovai wrote:
>>
>> I don’t think we want to have two separate full-screen modes. Seems really
>> confusing.
>
> While I kind of agree, the Lion folks are getting antsy.

I think that we should have only one full-screen mode available for
any window. If we want to use the Lion API on Lion, then we should
redirect the Chrome full-screen commands in the wrench menu and the
View menu to enter Lion full-screen mode, and not have Chrome
full-screen mode available.

If we need to tweak things further in Lion full-screen mode to show or
hide other UI elements, we can take things from there.

[Robert Sesek, 2011-07-13 15:12:10]

On 2011/07/13 14:51:36, Mark Mentovai wrote:
> mailto:rsesek@chromium.org wrote:
> > On 2011/07/13 14:46:04, Mark Mentovai wrote:
> >>
> >> I don’t think we want to have two separate full-screen modes. Seems really
> >> confusing.
> >
> > While I kind of agree, the Lion folks are getting antsy.
> 
> I think that we should have only one full-screen mode available for
> any window. If we want to use the Lion API on Lion, then we should
> redirect the Chrome full-screen commands in the wrench menu and the
> View menu to enter Lion full-screen mode, and not have Chrome
> full-screen mode available.
> 
> If we need to tweak things further in Lion full-screen mode to show or
> hide other UI elements, we can take things from there.

Rohit and I both like the current fullscreen implementation we have, but it's
not exactly Lion style. We probably need some UI decision here.

[keishi1, 2011-07-13 16:10:32]

After some more thinking,
I now realize that the Chrome full screen UI was carefully designed to deal with
both "presentation" and "maximized window" use cases.

However the current Lion implementation is irritating because the full screen
doesn't open in a new Screen.

The best solution is to go into Chrome full screen mode with the Lion APIs but
that is hard to implement it properly. 

Maybe we could land this patch for now (to please the Chromium users) and change
to the better solution before the next Chrome release.

If you think this is confusing too, please don't hesitate to reject my patch :-)
I was just looking for a quick patch towards my committer count. :-P

rsesek, mark I'm sorry for stirring things up.

PS I'm going to bed now so I will have fix the patch tomorrow morning.

[Mark Mentovai, 2011-07-13 16:14:57]

OK, we’ll bury this one then. No apology necessary.

If you’d like to work on implementing this properly, using the Chromium UI style
with the Lion full-screen API and the OS integration that brings, I think it’d
be a worthwhile project. As you say, it’s much more work. Robert and I have both
suggested ways to get started on that sort of implementation, and we’d both be
happy to discuss your design in more detail if you choose to do this. (Rohit
might be happy to discuss it too.)