Adding size and last modified time support to FileEnumerator and FileUtilProxy::Entry.

base/file_util_win.cc

Index: base/file_util_win.cc
diff --git a/base/file_util_win.cc b/base/file_util_win.cc
index 93bfe1dd042c9a326fa5eb78b34cd780dd2646e8..9bd0809aed89e4ee298ccd51a0f37db021a13bef 100644
--- a/base/file_util_win.cc
+++ b/base/file_util_win.cc
@@ -10,6 +10,7 @@
 #include <shellapi.h>
 #include <shlobj.h>
 #include <time.h>
+#include <limits>

[brettw, 2011/07/13 15:51:41]

Can you add a blank line here between the C & C++ includes?

[tzik, 2011/07/14 07:05:42]

Done.

 #include <string>
 
 #include "base/file_path.h"
@@ -893,6 +894,20 @@ FilePath FileEnumerator::GetFilename(const FindInfo& find_info) {
   return FilePath(find_info.cFileName);
 }
 
+// static
+int64 FileEnumerator::GetFilesize(const FindInfo& find_info) {
+  ULARGE_INTEGER size;
+  size.HighPart = find_info.nFileSizeHigh;
+  size.LowPart = find_info.nFileSizeLow;
+  DCHECK(size.QuadPart <= std::numeric_limits<int64>::max());

[brettw, 2011/07/13 15:51:41]

I probably wouldn't bother with this check, it's not clear to me what it helps.

[tzik, 2011/07/14 07:05:42]

Out of my cowardice,  QuadPart can be greater than 2^63 in thousands years
after.

[kinuko, 2011/07/14 07:18:17]

Long live chromium...

style-nit: it'd be better to use DCHECK_LE.

[tzik, 2011/07/14 10:42:45]

Done.

+  return static_cast<int64>(size.QuadPart);
+}
+
+// static
+base::Time FileEnumerator::GetLastModifiedTime(const FindInfo& find_info) {
+  return base::Time::FromFileTime(find_info.ftLastWriteTime);
+}
+
 FilePath FileEnumerator::Next() {
   base::ThreadRestrictions::AssertIOAllowed();