Adding size and last modified time support to FileEnumerator and FileUtilProxy::Entry.

webkit/fileapi/obfuscated_file_system_file_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/obfuscated_file_system_file_util.h"
 
 #include <queue>
 #include <vector>
 
 #include "base/file_util.h"
@@ skipping 156 matching lines @@
     base::PlatformFileInfo* file_info,
     FilePath* platform_file_path) {
   FileSystemDirectoryDatabase* db = GetDirectoryDatabase(
       context->src_origin_url(), context->src_type(), false);
   if (!db)
     return base::PLATFORM_FILE_ERROR_NOT_FOUND;
   FileId file_id;
   if (!db->GetFileWithPath(virtual_path, &file_id))
     return base::PLATFORM_FILE_ERROR_NOT_FOUND;
   FileInfo local_info;
   if (!db->GetFileInfo(file_id, &local_info)) {

[kinuko, 2011/07/13 07:56:51]

Maybe this part could also be included into the factored-out method?

[tzik, 2011/07/13 08:30:44]

Done.

     NOTREACHED();
     return base::PLATFORM_FILE_ERROR_FAILED;
   }
-  if (local_info.is_directory()) {
-    file_info->is_directory = true;
-    file_info->is_symbolic_link = false;
-    file_info->last_modified = local_info.modification_time;
-    *platform_file_path = FilePath();
-    // We don't fill in ctime or atime.
-    return base::PLATFORM_FILE_OK;
-  }
-  if (local_info.data_path.empty())
-    return base::PLATFORM_FILE_ERROR_INVALID_OPERATION;
-  FilePath data_path = DataPathToLocalPath(context->src_origin_url(),
-    context->src_type(), local_info.data_path);
-  return underlying_file_util_->GetFileInfo(
-      context, data_path, file_info, platform_file_path);
+  return GetPlatformFileInfo(context, file_id, local_info,
+                             file_info, platform_file_path);
 }
 
 PlatformFileError ObfuscatedFileSystemFileUtil::ReadDirectory(
     FileSystemOperationContext* context,
     const FilePath& virtual_path,
     std::vector<base::FileUtilProxy::Entry>* entries) {
   // TODO(kkanetkar): Implement directory read in multiple chunks.
   FileSystemDirectoryDatabase* db = GetDirectoryDatabase(
       context->src_origin_url(), context->src_type(), false);
   if (!db) {
@@ skipping 20 matching lines @@
   if (!db->ListChildren(file_id, &children)) {
     NOTREACHED();
     return base::PLATFORM_FILE_ERROR_FAILED;
   }
   std::vector<FileId>::iterator iter;
   for (iter = children.begin(); iter != children.end(); ++iter) {
     if (!db->GetFileInfo(*iter, &file_info)) {
       NOTREACHED();
       return base::PLATFORM_FILE_ERROR_FAILED;
     }
+
+    base::PlatformFileInfo platform_file_info;
+    FilePath file_path;
+    if (GetPlatformFileInfo(context, file_id, file_info,
+                            &platform_file_info, &file_path) !=
+        base::PLATFORM_FILE_OK) {
+      NOTREACHED();
+      return base::PLATFORM_FILE_ERROR_FAILED;
+    }
+
     base::FileUtilProxy::Entry entry;
     entry.name = file_info.name;
     entry.is_directory = file_info.is_directory();
+    entry.size = entry.is_directory ? 0 : platform_file_info.size;
+    entry.last_modified_time = platform_file_info.last_modified;
     entries->push_back(entry);
   }
   return base::PLATFORM_FILE_OK;
 }
 
 PlatformFileError ObfuscatedFileSystemFileUtil::CreateDirectory(
     FileSystemOperationContext* context,
     const FilePath& virtual_path,
     bool exclusive,
     bool recursive) {
@@ skipping 466 matching lines @@
 ObfuscatedFileSystemFileUtil::CreateFileEnumerator(
     FileSystemOperationContext* context,
     const FilePath& root_path) {
   FileSystemDirectoryDatabase* db = GetDirectoryDatabase(
       context->src_origin_url(), context->src_type(), false);
   if (!db)
     return new FileSystemFileUtil::EmptyFileEnumerator();
   return new ObfuscatedFileSystemFileEnumerator(db, root_path);
 }
 
+PlatformFileError ObfuscatedFileSystemFileUtil::GetPlatformFileInfo(

[kinuko, 2011/07/13 07:56:51]

This naming may be confusing as it could be returning some virtualized info
(though the structure name we're filling is indeed PlatformFileInfo). 
GetFileInfoInternal() or something might be better?

[tzik, 2011/07/13 08:30:44]

Done.

+    FileSystemOperationContext* context,
+    FileId file_id,
+    const FileInfo& local_info,
+    base::PlatformFileInfo* file_info,
+    FilePath* platform_file_path) {
+  FileSystemDirectoryDatabase* db = GetDirectoryDatabase(

[kinuko, 2011/07/13 07:56:51]

Can we pass this pointer as a parameter?  (Actually in this code path do we need
to do this?)

[tzik, 2011/07/13 08:30:44]

Done.

+      context->src_origin_url(), context->src_type(), false);
+  if (!db)
+    return base::PLATFORM_FILE_ERROR_NOT_FOUND;
+  if (local_info.is_directory()) {
+    file_info->is_directory = true;
+    file_info->is_symbolic_link = false;
+    file_info->last_modified = local_info.modification_time;
+    *platform_file_path = FilePath();
+    // We don't fill in ctime or atime.
+    return base::PLATFORM_FILE_OK;
+  }
+  if (local_info.data_path.empty())
+    return base::PLATFORM_FILE_ERROR_INVALID_OPERATION;
+  FilePath data_path = DataPathToLocalPath(context->src_origin_url(),
+    context->src_type(), local_info.data_path);
+  return underlying_file_util_->GetFileInfo(
+      context, data_path, file_info, platform_file_path);
+}
+
 PlatformFileError ObfuscatedFileSystemFileUtil::CreateFile(
     FileSystemOperationContext* context,
     const GURL& origin_url, FileSystemType type, const FilePath& source_path,
     FileInfo* file_info, int file_flags, PlatformFile* handle) {
   if (handle)
     *handle = base::kInvalidPlatformFileValue;
   FileSystemDirectoryDatabase* db = GetDirectoryDatabase(
       origin_url, type, true);
   int64 number;
   if (!db || !db->GetNextInteger(&number))
@@ skipping 313 matching lines @@
       return false;
     }
     origin_database_.reset(
         new FileSystemOriginDatabase(
             file_system_directory_.AppendASCII(kOriginDatabaseName)));
   }
   return true;
 }
 
 }  // namespace fileapi