Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: remoting/client/plugin/pepper_view.cc

Issue 7355011: Modify Chromoting logging to hook into base logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments + thread proxy Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_view.cc
diff --git a/remoting/client/plugin/pepper_view.cc b/remoting/client/plugin/pepper_view.cc
index 3def351acfd3724562aeffe8e5104075bd8e5b0c..9d35847e627eba45f48bd3cc0c0d804cc6c76797 100644
--- a/remoting/client/plugin/pepper_view.cc
+++ b/remoting/client/plugin/pepper_view.cc
@@ -48,16 +48,15 @@ void PepperView::Paint() {
TraceContext::tracer()->PrintString("Start Paint.");
if (is_static_fill_) {
- instance_->Log(logging::LOG_INFO,
- "Static filling %08x", static_fill_color_);
+ LOG(INFO) << "Static filling " << static_fill_color_;
pp::ImageData image(instance_, pp::ImageData::GetNativeImageDataFormat(),
pp::Size(graphics2d_.size().width(),
graphics2d_.size().height()),
false);
if (image.is_null()) {
- instance_->Log(logging::LOG_ERROR,
- "Unable to allocate image of size: %dx%d",
- graphics2d_.size().width(), graphics2d_.size().height());
+ LOG(ERROR) << "Unable to allocate image of size: "
+ << graphics2d_.size().width() << " x "
+ << graphics2d_.size().height();
return;
}
@@ -100,7 +99,7 @@ void PepperView::PaintFrame(media::VideoFrame* frame, UpdatedRects* rects) {
SetHostSize(gfx::Size(frame->width(), frame->height()));
if (!backing_store_.get() || backing_store_->is_null()) {
- instance_->Log(logging::LOG_ERROR, "Backing store is not available.");
+ LOG(ERROR) << "Backing store is not available.";
return;
}
@@ -241,7 +240,7 @@ bool PepperView::SetPluginSize(const gfx::Size& plugin_size) {
graphics2d_ = pp::Graphics2D(instance_, pp_size, true);
if (!instance_->BindGraphics(graphics2d_)) {
- instance_->Log(logging::LOG_ERROR, "Couldn't bind the device context.");
+ LOG(ERROR) << "Couldn't bind the device context.";
return false;
}
@@ -251,8 +250,8 @@ bool PepperView::SetPluginSize(const gfx::Size& plugin_size) {
// Allocate the backing store to save the desktop image.
if ((backing_store_.get() == NULL) ||
(backing_store_->size() != pp_size)) {
- instance_->Log(logging::LOG_INFO, "Allocate backing store: %d x %d",
- plugin_size.width(), plugin_size.height());
+ LOG(INFO) << "Allocate backing store: "
+ << plugin_size.width() << " x " << plugin_size.height();
backing_store_.reset(
new pp::ImageData(instance_, pp::ImageData::GetNativeImageDataFormat(),
pp_size, false));
@@ -300,7 +299,7 @@ void PepperView::ReleaseFrame(media::VideoFrame* frame) {
DCHECK(CurrentlyOnPluginThread());
if (frame) {
- instance_->Log(logging::LOG_WARNING, "Frame released.");
+ LOG(WARNING) << "Frame released.";
frame->Release();
}
}

Powered by Google App Engine
This is Rietveld 408576698