Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1786)

Unified Diff: remoting/client/plugin/pepper_view.cc

Issue 7355011: Modify Chromoting logging to hook into base logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add timestamp Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_view.cc
diff --git a/remoting/client/plugin/pepper_view.cc b/remoting/client/plugin/pepper_view.cc
index 6558a0408864034a03a1e6a6b8899773b0ae7264..89977bb6ac573fd83ad8868ac823401ada00b11b 100644
--- a/remoting/client/plugin/pepper_view.cc
+++ b/remoting/client/plugin/pepper_view.cc
@@ -54,15 +54,13 @@ void PepperView::Paint() {
// TODO(ajwong): We're assuming the native format is BGRA_PREMUL below. This
// is wrong.
if (is_static_fill_) {
- instance_->Log(logging::LOG_INFO,
- "Static filling %08x", static_fill_color_);
+ LOG(INFO) << "Static filling " << static_fill_color_;
pp::ImageData image(instance_, pp::ImageData::GetNativeImageDataFormat(),
pp::Size(host_width_, host_height_),
false);
if (image.is_null()) {
- instance_->Log(logging::LOG_ERROR,
- "Unable to allocate image of size: %dx%d",
- host_width_, host_height_);
+ LOG(ERROR) << "Unable to allocate image of size: "
+ << host_width_ << "x" << host_height_;
return;
}
@@ -98,13 +96,12 @@ void PepperView::PaintFrame(media::VideoFrame* frame, UpdatedRects* rects) {
const int kBytesPerPixel = GetBytesPerPixel(media::VideoFrame::RGB32);
if (!backing_store_.get() || backing_store_->is_null()) {
- instance_->Log(logging::LOG_ERROR, "Backing store is not available.");
+ LOG(ERROR) << "Backing store is not available.";
return;
}
if (DoScaling()) {
if (!scaled_backing_store_.get() || scaled_backing_store_->is_null()) {
- instance_->Log(logging::LOG_ERROR,
- "Scaled backing store is not available.");
+ LOG(ERROR) << "Scaled backing store is not available.";
}
}
@@ -345,7 +342,7 @@ void PepperView::ResizeInternals() {
pp::Size(host_width_, host_height_),
false);
if (!instance_->BindGraphics(graphics2d_)) {
- instance_->Log(logging::LOG_ERROR, "Couldn't bind the device context.");
+ LOG(ERROR) << "Couldn't bind the device context.";
return;
}
@@ -443,7 +440,7 @@ void PepperView::ReleaseFrame(media::VideoFrame* frame) {
DCHECK(CurrentlyOnPluginThread());
if (frame) {
- instance_->Log(logging::LOG_WARNING, "Frame released.");
+ LOG(WARNING) << "Frame released.";
frame->Release();
}
}

Powered by Google App Engine
This is Rietveld 408576698