Issue 7354027: Convert *.js files of cctest/test-log into "resources".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7354027: Convert *.js files of cctest/test-log into "resources". (Closed)

Created:
9 years, 5 months ago by mnaganov (inactive)

Modified:
9 years, 5 months ago

Reviewers:
Søren Thygesen Gjesse, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Convert *.js files of cctest/test-log into "resources". This allows running cctest from anywhere. I was to rename single-letter variables in my script due to an encountered issue in JSMin (http://code.google.com/p/v8/issues/detail?id=1557). R=svenpanne@chromium.org,sgjesse@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8654

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -41 lines)			Patch
M	src/natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/SConscript	View	2 chunks	+24 lines, -0 lines	2 comments	Download
M	test/cctest/log-eq-of-logging-and-traversal.js	View	1 chunk	+12 lines, -10 lines	0 comments	Download
M	test/cctest/test-log.cc	View	3 chunks	+20 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM apart from tiny style issue. http://codereview.chromium.org/7354027/diff/1/test/cctest/SConscript File test/cctest/SConscript (right): http://codereview.chromium.org/7354027/diff/1/test/cctest/SConscript#newcode37 test/cctest/SConscript:37: JS_FILES_FOR_TESTS = ''' ...

9 years, 5 months ago (2011-07-14 08:06:42 UTC) #2

mnaganov (inactive)

9 years, 5 months ago (2011-07-14 11:36:25 UTC) #3

http://codereview.chromium.org/7354027/diff/1/test/cctest/SConscript
File test/cctest/SConscript (right):

http://codereview.chromium.org/7354027/diff/1/test/cctest/SConscript#newcode37
test/cctest/SConscript:37: JS_FILES_FOR_TESTS = '''
On 2011/07/14 08:06:42, Sven wrote:
> Tiny style issue: JS_FILES_FOR_TESTS = [ 'blah', 'foo', ... ] would be more
> consistent that using split().

Fixed!

Expand Messages | Collapse Messages