Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: SConstruct

Issue 7351017: Introduces a light version of D8 that links against shared library. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: minor correction Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/SConscript » ('j') | src/d8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index 5276ce2cae6e2769cfeecb11f48f5e4f060ed37b..85d275013c95c3f59b2007268e7b2dc4b3b57cc3 100644
--- a/SConstruct
+++ b/SConstruct
@@ -773,6 +773,13 @@ PREPARSER_FLAGS = {
D8_FLAGS = {
+ 'all': {
+ 'library:shared': {
+ 'CPPDEFINES': ['USING_V8_SHARED'],
Søren Thygesen Gjesse 2011/07/13 14:12:38 The define USING_V8_SHARED is for Windows. On the
+ 'LIBS': ['v8'],
+ 'LIBPATH': ['.']
+ },
+ },
'gcc': {
'all': {
'CCFLAGS': ['$DIALECTFLAGS', '$WARNINGFLAGS'],
@@ -1370,7 +1377,11 @@ def BuildSpecific(env, mode, env_overrides, tools):
d8_env = Environment(tools=tools)
d8_env.Replace(**context.flags['d8'])
context.ApplyEnvOverrides(d8_env)
- shell = d8_env.Program('d8' + suffix, object_files + shell_files)
+ if context.options['library'] == 'static':
+ shell = d8_env.Program('d8' + suffix, object_files + shell_files)
+ else:
+ shell = d8_env.Program('d8' + suffix, shell_files)
+ d8_env.Depends(shell, library)
context.d8_targets.append(shell)
for sample in context.samples:
« no previous file with comments | « no previous file | src/SConscript » ('j') | src/d8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698