media/audio/win/audio_manager_win.cc - Issue 7351003: Clean up users of a deprecated base::LaunchApp API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/win/audio_manager_win.cc

Issue 7351003: Clean up users of a deprecated base::LaunchApp API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: win Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/win/audio_manager_win.cc

diff --git a/media/audio/win/audio_manager_win.cc b/media/audio/win/audio_manager_win.cc

index 6406b21aa8a1ad9e4526cc072771ffc13deb8f40..9a882f8de5d3cc3f0550536581d217abecab45e7 100644

--- a/media/audio/win/audio_manager_win.cc

+++ b/media/audio/win/audio_manager_win.cc

@@ -250,7 +250,8 @@ void AudioManagerWin::ShowAudioInputSettings() {

path = path.Append(program);

CommandLine command_line(path);

command_line.AppendArg(argument);

- base::LaunchApp(command_line, false, false, NULL);

+ base::LaunchOptions options;

+ base::LaunchProcess(command_line, options);

Mark Mentovai 2011/07/14 18:17:22 Seeing this pattern repeatedly makes me wonder if

}

void AudioManagerWin::GetAudioInputDeviceNames(

« no previous file with comments | « media/audio/linux/audio_manager_linux.cc ('k') | net/disk_cache/stress_cache.cc » ('j') | no next file with comments »