Issue 7350019: Fix shortcutting bug in HInferRepresentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7350019: Fix shortcutting bug in HInferRepresentation (Closed)

Created:
9 years, 5 months ago by wingo

Modified:
9 years, 5 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix shortcutting bug in HInferRepresentation * src/hydrogen.cc (HInferRepresentation::Analyze): Fix iterative loop over phis; the shortcutting behavior of || appears to be accidental here, causing O(n^2) convergence. Not that it matters much, but hey! While I'm at it, a minor comment fix: * src/hydrogen-instructions.h (EnsureAndPropagateNotMinusZero): Fix a comment about the kinds of instructions that propagate to multiple inputs. BUG= TEST=passes tools/test.py Committed: http://code.google.com/p/v8/source/detail?r=8645

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/hydrogen-instructions.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Nice catch! :-)

I will land it.

Expand Messages | Collapse Messages