Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/platform-win32.cc

Issue 7350014: Remove the ability to compile without logging and profiling (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review comments Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/platform-solaris.cc ('k') | src/profile-generator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1821 matching lines...) Expand 10 before | Expand all | Expand 10 after
1832 uint32_t Socket::NToH(uint32_t value) { 1832 uint32_t Socket::NToH(uint32_t value) {
1833 return ntohl(value); 1833 return ntohl(value);
1834 } 1834 }
1835 1835
1836 1836
1837 Socket* OS::CreateSocket() { 1837 Socket* OS::CreateSocket() {
1838 return new Win32Socket(); 1838 return new Win32Socket();
1839 } 1839 }
1840 1840
1841 1841
1842 #ifdef ENABLE_LOGGING_AND_PROFILING
1843
1844 // ---------------------------------------------------------------------------- 1842 // ----------------------------------------------------------------------------
1845 // Win32 profiler support. 1843 // Win32 profiler support.
1846 1844
1847 class Sampler::PlatformData : public Malloced { 1845 class Sampler::PlatformData : public Malloced {
1848 public: 1846 public:
1849 // Get a handle to the calling thread. This is the thread that we are 1847 // Get a handle to the calling thread. This is the thread that we are
1850 // going to profile. We need to make a copy of the handle because we are 1848 // going to profile. We need to make a copy of the handle because we are
1851 // going to use it in the sampler thread. Using GetThreadHandle() will 1849 // going to use it in the sampler thread. Using GetThreadHandle() will
1852 // not work in this case. We're using OpenThread because DuplicateHandle 1850 // not work in this case. We're using OpenThread because DuplicateHandle
1853 // for some reason doesn't work in Chrome's sandbox. 1851 // for some reason doesn't work in Chrome's sandbox.
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
2008 SamplerThread::AddActiveSampler(this); 2006 SamplerThread::AddActiveSampler(this);
2009 } 2007 }
2010 2008
2011 2009
2012 void Sampler::Stop() { 2010 void Sampler::Stop() {
2013 ASSERT(IsActive()); 2011 ASSERT(IsActive());
2014 SamplerThread::RemoveActiveSampler(this); 2012 SamplerThread::RemoveActiveSampler(this);
2015 SetActive(false); 2013 SetActive(false);
2016 } 2014 }
2017 2015
2018 #endif // ENABLE_LOGGING_AND_PROFILING
2019 2016
2020 } } // namespace v8::internal 2017 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/platform-solaris.cc ('k') | src/profile-generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698