Changed SPDY's ip connection pooling logic to only add the used IP,

net/spdy/spdy_session_unittest.cc

Index: net/spdy/spdy_session_unittest.cc
===================================================================
--- net/spdy/spdy_session_unittest.cc	(revision 92397)
+++ net/spdy/spdy_session_unittest.cc	(working copy)
@@ -417,8 +417,8 @@
     std::string iplist;
     HostPortProxyPair pair;
   } test_hosts[] = {
-    { "www.foo.com",    "192.168.0.1,192.168.0.5" },
-    { "images.foo.com", "192.168.0.2,192.168.0.3,192.168.0.5" },
+    { "www.foo.com",    "192.0.2.33,192.168.0.1,192.168.0.5" },
+    { "images.foo.com", "192.168.0.2,192.168.0.3,192.168.0.5,192.0.2.33" },
     { "js.foo.com",     "192.168.0.4,192.168.0.3" },
   };
 
@@ -477,6 +477,12 @@
                              BoundNetLog()));
   EXPECT_EQ(OK, session->InitializeWithSocket(connection.release(), false, OK));
 
+  // MockClientSocket::GetPeerAddress return's 0 as the port number for the
+  // host. HasSession looks up addresses with port 80. AddAliases adds addresses
+  // with port 80 into session_pool's aliases for |test_hosts[0].pair|.
+  SpdySessionPoolPeer pool_peer(spdy_session_pool);
+  pool_peer.AddAliases(test_hosts[0].pair);

[willchan no longer on Chromium, 2011/07/17 12:44:47]

Sorry, I wasn't clear. I'd prefer you just do AddAlias() rather than
AddAliases(). The reason is that this more closely mirrors what the code is
actually doing now. When we create a new SpdySession, we add only one
ipport=>hostname mapping in InitalizeWithSocket(). That's why I think it's wrong
to have an AddAliases() which adds multiple mappings. I think you should only
add the single mapping.

That said, I think we can also fix this by changing
MockClientsocket::GetPeerAddress() to return port 80. That's the more typical
port to return. We shouldn't be returning 0. I don't think anything will break
if you do this, but if something breaks and it looks nontrivial to fix, don't
worry about it and just use pool_peer.AddAlias().

[ramant (doing other things), 2011/07/17 19:45:34]

Done.

+
   // Flush the SpdySession::OnReadComplete() task.
   MessageLoop::current()->RunAllPending();