Changed SPDY's ip connection pooling logic to only add the used IP,

net/spdy/spdy_session_pool.h

Index: net/spdy/spdy_session_pool.h
===================================================================
--- net/spdy/spdy_session_pool.h	(revision 92397)
+++ net/spdy/spdy_session_pool.h	(working copy)
@@ -130,7 +130,14 @@
  private:
   friend class SpdySessionPoolPeer;  // For testing.
   friend class SpdyNetworkTransactionTest;  // For testing.
+  friend class SpdySessionTest;  // For testing.

[willchan no longer on Chromium, 2011/07/17 01:23:45]

Rather than add all of these friends, can you just use the SpdySessionPoolPeer?
That's the friended class that you can change to expose whatever functionality
you want. That way we don't need to add all these ugly/fragile FRIEND_TEST
macros.

[ramant (doing other things), 2011/07/17 08:12:30]

Done.

   FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionTest, WindowUpdateOverflow);
+  FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, GoAway);
+  FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, OnSettings);
+  FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, CancelPendingCreateStream);
+  FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, SendSettingsOnNewSession);
+  FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, IPPoolingTest);
+  FRIEND_TEST_ALL_PREFIXES(SSLClientSocketPoolTest, IPPooling);
 
   typedef std::list<scoped_refptr<SpdySession> > SpdySessionList;
   typedef std::map<HostPortProxyPair, SpdySessionList*> SpdySessionsMap;
@@ -163,8 +170,9 @@
   bool LookupAddresses(const HostPortProxyPair& pair,
                        AddressList* addresses) const;
 
-  // Add a set of |addresses| as IP-equivalent addresses for |pair|.
-  void AddAliases(const AddressList& addresses, const HostPortProxyPair& pair);
+  // Add the addresses from LookupAddresses for |pair| as IP-equivalent
+  // addresses for |pair|. Used by unit tests only.

[willchan no longer on Chromium, 2011/07/17 01:23:45]

This seems a bit weird, since for LookupAddresses(), that means we'd have to
pre-populate the HostCache in the test. I suggest just allowing AddAlias() to
add whatever value. Perhaps you should rename this to AddAlias(const IPEndPoint&
endpoint, const HostPortProxyPair& pair);

[ramant (doing other things), 2011/07/17 08:12:30]

Done.

+  void AddAliases(const HostPortProxyPair& pair);
 
   // Remove all aliases for |pair| from the aliases table.
   void RemoveAliases(const HostPortProxyPair& pair);