Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 7349020: Don't show a prompt when loading an extension with NPAPI plugins via (Closed)

Created:
9 years, 5 months ago by Matt Perry
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews
Visibility:
Public.

Description

Don't show a prompt when loading an extension with NPAPI plugins via --load-extension. BUG=89075 TEST=load an extension with an NPAPI plugin via --load-extension and via the extension managment page. Only the latter should prompt with an install dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92310

Patch Set 1 #

Patch Set 2 : compile fix #

Patch Set 3 : unit test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -52 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 8 chunks +51 lines, -49 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Matt Perry
I also did some minor cleanup to remove the return value checks on PostTask, since ...
9 years, 5 months ago (2011-07-12 21:17:07 UTC) #1
asargent_no_longer_on_chrome
LGTM
9 years, 5 months ago (2011-07-12 21:41:33 UTC) #2
commit-bot: I haz the power
Presubmit check for 7349020-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 5 months ago (2011-07-12 22:28:17 UTC) #3
Matt Perry
+miranda for profiles/ approval
9 years, 5 months ago (2011-07-12 22:29:35 UTC) #4
commit-bot: I haz the power
Presubmit check for 7349020-7001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 5 months ago (2011-07-12 22:43:35 UTC) #5
Miranda Callahan
On 2011/07/12 22:43:35, I haz the power (commit-bot) wrote: > Presubmit check for 7349020-7001 failed ...
9 years, 5 months ago (2011-07-13 00:13:39 UTC) #6
commit-bot: I haz the power
9 years, 5 months ago (2011-07-13 03:40:46 UTC) #7
Change committed as 92310

Powered by Google App Engine
This is Rietveld 408576698