chrome/renderer/print_web_view_helper_win.cc - Issue 7348010: Added Header and Footer support using Skia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_win.cc

Issue 7348010: Added Header and Footer support using Skia (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Remove header_footer_info from settings Dictionary. Changes as per Steve and Kausalya's comments. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/print_web_view_helper_win.cc

diff --git a/chrome/renderer/print_web_view_helper_win.cc b/chrome/renderer/print_web_view_helper_win.cc

index 477b37835382f0424e3ee7030ed1a894783f590c..6bf4d24b2fae30dd04b4582f5c54d28919f2e042 100644

--- a/chrome/renderer/print_web_view_helper_win.cc

+++ b/chrome/renderer/print_web_view_helper_win.cc

@@ -195,6 +195,15 @@ void PrintWebViewHelper::RenderPage(

}

float webkit_scale_factor = frame->printPage(page_number, canvas.get());

+ if (is_preview && params.display_header_footer) {

+ // |page_number| is 0-based, so 1 is added.

+ PrintHeaderAndFooter(device, canvas.get(), page_number + 1,

+ print_preview_context_.total_page_count(),

+ webkit_scale_factor, page_layout_in_points,

+ *header_footer_info_);

+ }

if (*scale_factor <= 0 || webkit_scale_factor <= 0) {

NOTREACHED() << "Printing page " << page_number << " failed.";

} else {