Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: chrome/browser/ui/webui/print_preview_handler.cc

Issue 7348010: Added Header and Footer support using Skia (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Removed header_footer_info param from IPC call. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc
index 5e1c0aad2d9a924b6f9ba82ae42e17929bcdca20..efa47cb42cf3044159b9f623d5958cab6a798392 100644
--- a/chrome/browser/ui/webui/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview_handler.cc
@@ -483,6 +483,22 @@ void PrintPreviewHandler::HandleGetPreview(const ListValue* args) {
print_preview_ui->OnPrintPreviewFailed();
return;
}
+
+ bool display_header_footer;
Chris Guillory 2011/07/26 00:10:45 This local isn't used. Do you just want to DCHECK(
Aayush Kumar 2011/07/26 01:55:41 Sorry - this was deprecated code. Removed. On 201
+ if (!settings->GetBoolean(printing::kSettingHeaderFooter,
+ &display_header_footer)) {
+ NOTREACHED();
+ }
+
+ // Retrieving the page title and url and sending it to the renderer process.
Chris Guillory 2011/07/26 00:10:45 Nit: Retrieving -> Retrieve sending -> send
Aayush Kumar 2011/07/26 01:55:41 Done.
+ settings->SetString(printing::kSettingHeaderFooterTitle,
+ initiator_tab->GetTitle());
+ std::string url;
+ NavigationEntry* entry = initiator_tab->controller().GetActiveEntry();
+ if (entry)
+ url = entry->virtual_url().spec();
+ settings->SetString(printing::kSettingHeaderFooterURL, url);
+
VLOG(1) << "Print preview request start";
RenderViewHost* rvh = initiator_tab->render_view_host();
rvh->Send(new PrintMsg_PrintPreview(rvh->routing_id(), *settings));

Powered by Google App Engine
This is Rietveld 408576698