Added Header and Footer support using Skia

chrome/browser/ui/webui/print_preview_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview_handler.h"
 
 #include <string>
 
 #include "base/base64.h"
 #if !defined(OS_CHROMEOS)
@@ skipping 465 matching lines @@
 
   TabContents* initiator_tab = GetInitiatorTab();
   if (!initiator_tab) {
     if (!reported_failed_preview_) {
       ReportUserActionHistogram(PREVIEW_FAILED);
       reported_failed_preview_ = true;
     }
     print_preview_ui->OnPrintPreviewFailed();
     return;
   }
+
+  bool isHeaderFooter;
+  if (!settings->GetBoolean(printing::kSettingHeaderFooter, &isHeaderFooter)) {

[kmadhusu, 2011/07/14 01:50:15]

nit: Remove {}
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Condit...

[Aayush Kumar, 2011/07/19 01:20:30]

It's now a multi-line if condition so braces have been retained
On 2011/07/14 01:50:15, kmadhusu wrote:

+    NOTREACHED();
+  }
+
+  // If the user has checked the Headers and footers option then we go ahead
+  // and retrieve the page URL and title since we're already in the browser
+  // process and send it along to the renderer along with other print settings.
+  // No point going back to the renderer and then making an explicit call to

[kmadhusu, 2011/07/14 01:50:15]

Provide a simple comment. No need to specify any details on why you are creating
a dictionary here.

[Aayush Kumar, 2011/07/19 01:20:30]

Done.

+  // the browser process again to retrieve this information.
+  DictionaryValue header_footer_info;
+  if (isHeaderFooter) {
+    header_footer_info.SetString(printing::kSettingHeaderFooterTitle,
+        initiator_tab->GetTitle());
+
+    NavigationEntry* entry = initiator_tab->controller().GetActiveEntry();
+    if (entry) {
+      header_footer_info.SetString(printing::kSettingHeaderFooterURL,
+          entry->virtual_url().spec());
+    } else {
+      header_footer_info.SetString(printing::kSettingHeaderFooterURL, "");

[kmadhusu, 2011/07/14 01:50:15]

How about: 

std::string footer_url;
NavigationEntry* entry = initiator_tab->controller().GetActiveEntry();
if (entry)
  footer_url = entry->virtual_url().spec();

header_footer_info.SetString(printing::kSettingHeaderFooterURL, footer_url);

[Aayush Kumar, 2011/07/19 01:20:30]

Done.

+    }
+  }
+
   VLOG(1) << "Print preview request start";
   RenderViewHost* rvh = initiator_tab->render_view_host();
-  rvh->Send(new PrintMsg_PrintPreview(rvh->routing_id(), *settings));
+  rvh->Send(new PrintMsg_PrintPreview(rvh->routing_id(), *settings,
+            header_footer_info));

[kmadhusu, 2011/07/14 01:50:15]

As thestig suggested, header_footer_info can be a part of |settings|. You can
remove it from the dictionary in print_web_view_helper. 

[Aayush Kumar, 2011/07/19 01:20:30]

I discussed it with him and in person and put a small comment in the small
review - I think he is now alright regarding the additional parameter since the
header footer strings aren't really a part of print settings and don't need to
be passed around with them.
On 2011/07/14 01:50:15, kmadhusu wrote:

 }
 
 void PrintPreviewHandler::HandlePrint(const ListValue* args) {
   ReportStats();
 
   // Record the number of times the user requests to regenerate preview data
   // before printing.
   UMA_HISTOGRAM_COUNTS("PrintPreview.RegeneratePreviewRequest.BeforePrint",
                        regenerate_preview_request_count_);
 
@@ skipping 371 matching lines @@
     return;
 
   // We no longer require the initiator tab details. Remove those details
   // associated with the preview tab to allow the initiator tab to create
   // another preview tab.
   printing::PrintPreviewTabController* tab_controller =
      printing::PrintPreviewTabController::GetInstance();
   if (tab_controller)
     tab_controller->EraseInitiatorTabInfo(preview_tab());
 }