Clean up users of a deprecated base::LaunchApp API.

base/test/multiprocess_test.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TEST_MULTIPROCESS_TEST_H_
 #define BASE_TEST_MULTIPROCESS_TEST_H_
 #pragma once
 
 #include <string>
 
@@ skipping 40 matching lines @@
   //
   // Example signature:
   //    extern "C" int __declspec(dllexport) FooBar() {
   //         // do client work here
   //    }
   //
   // Returns the handle to the child, or NULL on failure
   ProcessHandle SpawnChild(const std::string& procname, bool debug_on_start);
 
 #if defined(OS_POSIX)
+  // TODO(evan): see if we can delete this via more refactoring.
   ProcessHandle SpawnChild(const std::string& procname,
                            const file_handle_mapping_vector& fds_to_map,
                            bool debug_on_start);
 #endif
 
   // Set up the command line used to spawn the child process.
   virtual CommandLine MakeCmdLine(const std::string& procname,
                                   bool debug_on_start);
 
  private:
-#if defined(OS_WIN)
-  ProcessHandle SpawnChildImpl(const std::string& procname,
-                               bool debug_on_start);
-
-#elif defined(OS_POSIX)
-  // TODO(port): with the CommandLine refactoring, this code is very similar
-  // to the Windows code.  Investigate whether this can be made shorter.
   ProcessHandle SpawnChildImpl(const std::string& procname,
                                const file_handle_mapping_vector& fds_to_map,

[Mark Mentovai, 2011/07/12 20:45:00]

This argument is still unused on Windows. Mention that in a comment? Having it
here in cross-platform code is kind of gnarly, but maybe less so than the
#ifdef.

[Evan Martin, 2011/07/12 21:22:29]

I think my eventual refactoring target here is have the LaunchOptions come in
from the caller, so it'll be up to the caller to ifdef.  I figured this was one
step along that path.  I'll add comments.

                                bool debug_on_start);
-#endif
 
   DISALLOW_COPY_AND_ASSIGN(MultiProcessTest);
 };
 
 }  // namespace base
 
 #endif  // BASE_TEST_MULTIPROCESS_TEST_H_