Issue 7345020: Add a network state notification interface to Pepper. Some plugins will need

Issue 7345020: Add a network state notification interface to Pepper. Some plugins will need (Closed)

Created:
9 years, 5 months ago by brettw

Modified:
9 years, 5 months ago

Reviewers:
darin (slow to review), noelallen_use_chromium

CC:
chromium-reviews, piman+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a network state notification interface to Pepper. Some plugins will need to know when the network goes up and down to do reconnection. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92256

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	A	ppapi/c/dev/ppp_network_state_dev.h	View	1 2	1 chunk	+27 lines, -0 lines	0 comments	Download
	M	ppapi/ppapi_cpp.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

http://codereview.chromium.org/7345020/diff/1/ppapi/c/dev/ppp_network_state_dev.h File ppapi/c/dev/ppp_network_state_dev.h (right): http://codereview.chromium.org/7345020/diff/1/ppapi/c/dev/ppp_network_state_dev.h#newcode7 ppapi/c/dev/ppp_network_state_dev.h:7: I guess you actually need to define the interface ...

9 years, 5 months ago (2011-07-12 21:38:47 UTC) #3

noelallen_use_chromium

If you could add the missing @file comment. The IDL requires a copyright notice and ...

9 years, 5 months ago (2011-07-12 21:56:52 UTC) #4

brettw

http://codereview.chromium.org/7345020/diff/4/ppapi/c/dev/ppp_network_state_dev.h File ppapi/c/dev/ppp_network_state_dev.h (right): http://codereview.chromium.org/7345020/diff/4/ppapi/c/dev/ppp_network_state_dev.h#newcode7 ppapi/c/dev/ppp_network_state_dev.h:7: Thanks, also added this to the .gypi file.

9 years, 5 months ago (2011-07-12 22:17:24 UTC) #5

LGTM

Expand Messages | Collapse Messages