Issue 7345: Fixes bug 1426704....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7345: Fixes bug 1426704.... (Closed)

Created:
12 years, 2 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixes bug 1426704. Constructors no longer print out their source code. They print [native code] instead. Some web applications don't like constructors with complex ToString results. Committed: http://code.google.com/p/v8/source/detail?r=506

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/runtime.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years, 2 months ago (2008-10-15 09:37:39 UTC) #2

LGTM

http://codereview.chromium.org/7345/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/7345/diff/1/2#newcode895
Line 895: // SetCode is only used for constructors, and some web code
Would:

"builtin constructors such as Function, String and Array"

make it clearer?

Expand Messages | Collapse Messages