Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 7344022: Add COMPONENT_BUILD global define. (Closed)

Created:
9 years, 5 months ago by darin (slow to review)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add COMPONENT_BUILD global define. This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson,evan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92409

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -62 lines) Patch
M base/at_exit.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 3 3 chunks +36 lines, -13 lines 0 comments Download
M base/base_api.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/debug_on_start_win.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M base/logging.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M crypto/crypto.gyp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M crypto/crypto_api.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_api.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/ssl_false_start_blacklist.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/net.gyp View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
M sandbox/sandbox.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/resource/resource_bundle_dummy.cc View 1 2 3 3 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
darin (slow to review)
http://codereview.chromium.org/7344022/diff/4001/base/base.gypi File base/base.gypi (right): http://codereview.chromium.org/7344022/diff/4001/base/base.gypi#newcode634 base/base.gypi:634: 'target_name': 'base_i18n_nacl_win64', This target is required since icu_util::Initialize is ...
9 years, 5 months ago (2011-07-12 22:25:30 UTC) #1
rvargas (doing something else)
We should also update crypto.gyp http://codereview.chromium.org/7344022/diff/4001/net/net.gyp File net/net.gyp (right): http://codereview.chromium.org/7344022/diff/4001/net/net.gyp#newcode827 net/net.gyp:827: 'conditions': [ We can ...
9 years, 5 months ago (2011-07-12 22:45:54 UTC) #2
darin (slow to review)
PTAL
9 years, 5 months ago (2011-07-12 22:56:36 UTC) #3
rvargas (doing something else)
LGTM
9 years, 5 months ago (2011-07-12 22:58:09 UTC) #4
bradn
LGTM Do keep an eye on the nacl_integration stage on try jobs before you commit.
9 years, 5 months ago (2011-07-12 23:47:22 UTC) #5
commit-bot: I haz the power
Change committed as 92325
9 years, 5 months ago (2011-07-13 07:12:37 UTC) #6
darin (slow to review)
On 2011/07/13 07:12:37, I haz the power (commit-bot) wrote: > Change committed as 92325 Was ...
9 years, 5 months ago (2011-07-13 17:52:45 UTC) #7
darin (slow to review)
I made one change in the latest CL: In base/logging.h, I now have this patch: ...
9 years, 5 months ago (2011-07-13 20:15:34 UTC) #8
darin (slow to review)
Also, I tested locally that a linux component build compiles.
9 years, 5 months ago (2011-07-13 20:15:59 UTC) #9
bradn
LGTM 2nd time's the charm :-)
9 years, 5 months ago (2011-07-13 20:22:56 UTC) #10
Evan Martin
9 years, 5 months ago (2011-07-13 20:39:29 UTC) #11
base LGTM (though I don't uflly understand the gyp changes)

Powered by Google App Engine
This is Rietveld 408576698