Issue 7344009: Move the time conversion code to the PPAPI shared_impl directory and use it in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7344009: Move the time conversion code to the PPAPI shared_impl directory and use it in (Closed)

Created:
9 years, 5 months ago by brettw

Modified:
9 years, 5 months ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move the time conversion code to the PPAPI shared_impl directory and use it in the proxy for converting event times. This also removes the unnecessary GetInterface function from Graphics2D and has the module use the thunk directly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92229

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -126 lines)			Patch
M	ppapi/ppapi_shared.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_core_proxy.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
A +	ppapi/shared_impl/time_conversion.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
A +	ppapi/shared_impl/time_conversion.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/event_conversion.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/file_callbacks.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_file_io_impl.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_file_ref_impl.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_file_impl.cc	View	3 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	webkit/plugins/ppapi/time_conversion.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	webkit/plugins/ppapi/time_conversion.cc	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	webkit/plugins/ppapi/time_conversion_unittest.cc	View	2 chunks	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages