Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: chrome/browser/content_settings/content_settings_abstract_provider.cc

Issue 7344008: Make the hcsm and its providers communicate via an observer interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_abstract_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_abstract_provider.cc b/chrome/browser/content_settings/content_settings_abstract_provider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5ba0be2630a17a2e4073548bb7c5ba87806bb0f1
--- /dev/null
+++ b/chrome/browser/content_settings/content_settings_abstract_provider.cc
@@ -0,0 +1,38 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/content_settings/content_settings_abstract_provider.h"
+
+class ContentSettingsDetails;
+
+namespace content_settings {
+
+AbstractProvider::AbstractProvider() {
+}
+
+AbstractProvider::~AbstractProvider() {
Bernhard Bauer 2011/07/13 07:58:18 Can you add a |DCHECK(observers_.empty())|?
markusheintz_ 2011/07/13 12:48:16 Done.
Bernhard Bauer 2011/07/13 13:21:28 Actually, now that you use an |ObserverList| you c
markusheintz_ 2011/07/13 14:14:42 Done.
+}
+
+void AbstractProvider::AddObserver(Observer* observer) {
+ observers_.insert(observer);
+}
+
+void AbstractProvider::RemoveObserver(Observer* observer) {
+ observers_.erase(observer);
+}
+
+void AbstractProvider::NotifyObservers(
+ const ContentSettingsDetails& details) const {
+ for (ObserverSet::const_iterator observer = observers_.begin();
+ observer != observers_.end();
+ ++observer) {
+ (*observer)->OnContentSettingChanged(details);
+ }
+}
+
+void AbstractProvider::RemoveAllObserver() {
+ observers_.clear();
+}
+
+} // namespace content_settings

Powered by Google App Engine
This is Rietveld 408576698