Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/content_settings/host_content_settings_map.cc

Issue 7344008: Make the hcsm and its providers communicate via an observer interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: "remove commented code" Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/content_settings/host_content_settings_map.h" 5 #include "chrome/browser/content_settings/host_content_settings_map.h"
6 6
7 #include <list> 7 #include <list>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/browser/content_settings/content_settings_details.h"
12 #include "chrome/browser/content_settings/content_settings_extension_provider.h" 13 #include "chrome/browser/content_settings/content_settings_extension_provider.h"
13 #include "chrome/browser/content_settings/content_settings_policy_provider.h" 14 #include "chrome/browser/content_settings/content_settings_policy_provider.h"
14 #include "chrome/browser/content_settings/content_settings_pref_provider.h" 15 #include "chrome/browser/content_settings/content_settings_pref_provider.h"
15 #include "chrome/browser/content_settings/content_settings_provider.h" 16 #include "chrome/browser/content_settings/content_settings_provider.h"
16 #include "chrome/browser/content_settings/content_settings_utils.h" 17 #include "chrome/browser/content_settings/content_settings_utils.h"
17 #include "chrome/browser/extensions/extension_service.h" 18 #include "chrome/browser/extensions/extension_service.h"
18 #include "chrome/browser/prefs/pref_service.h" 19 #include "chrome/browser/prefs/pref_service.h"
19 #include "chrome/browser/prefs/scoped_user_pref_update.h" 20 #include "chrome/browser/prefs/scoped_user_pref_update.h"
20 #include "chrome/browser/profiles/profile.h" 21 #include "chrome/browser/profiles/profile.h"
21 #include "chrome/common/chrome_notification_types.h" 22 #include "chrome/common/chrome_notification_types.h"
(...skipping 26 matching lines...) Expand all
48 typedef std::vector<DefaultContentSettingsProviderPtr>::iterator 49 typedef std::vector<DefaultContentSettingsProviderPtr>::iterator
49 DefaultProviderIterator; 50 DefaultProviderIterator;
50 typedef std::vector<DefaultContentSettingsProviderPtr>::const_iterator 51 typedef std::vector<DefaultContentSettingsProviderPtr>::const_iterator
51 ConstDefaultProviderIterator; 52 ConstDefaultProviderIterator;
52 53
53 typedef linked_ptr<content_settings::ProviderInterface> ProviderPtr; 54 typedef linked_ptr<content_settings::ProviderInterface> ProviderPtr;
54 typedef std::vector<ProviderPtr>::iterator ProviderIterator; 55 typedef std::vector<ProviderPtr>::iterator ProviderIterator;
55 typedef std::vector<ProviderPtr>::const_iterator ConstProviderIterator; 56 typedef std::vector<ProviderPtr>::const_iterator ConstProviderIterator;
56 57
57 typedef content_settings::ProviderInterface::Rules Rules; 58 typedef content_settings::ProviderInterface::Rules Rules;
58 typedef content_settings::ProviderInterface::Rules::iterator
59 rules_iterator;
60 typedef content_settings::ProviderInterface::Rules::const_iterator
61 const_rules_iterator;
62 59
63 const char* kProviderNames[] = { 60 const char* kProviderNames[] = {
64 "policy", 61 "policy",
65 "extension", 62 "extension",
66 "preference" 63 "preference"
67 }; 64 };
68 65
69 } // namespace 66 } // namespace
70 67
71 HostContentSettingsMap::HostContentSettingsMap( 68 HostContentSettingsMap::HostContentSettingsMap(
(...skipping 30 matching lines...) Expand all
102 UserMetrics::RecordAction( 99 UserMetrics::RecordAction(
103 UserMetricsAction("ThirdPartyCookieBlockingDisabled")); 100 UserMetricsAction("ThirdPartyCookieBlockingDisabled"));
104 } 101 }
105 is_block_third_party_cookies_managed_ = 102 is_block_third_party_cookies_managed_ =
106 prefs_->IsManagedPreference(prefs::kBlockThirdPartyCookies); 103 prefs_->IsManagedPreference(prefs::kBlockThirdPartyCookies);
107 104
108 // User defined non default content settings are provided by the PrefProvider. 105 // User defined non default content settings are provided by the PrefProvider.
109 // The order in which the content settings providers are created is critical, 106 // The order in which the content settings providers are created is critical,
110 // as providers that are further up in the list (i.e. added earlier) override 107 // as providers that are further up in the list (i.e. added earlier) override
111 // providers further down. 108 // providers further down.
112 content_settings_providers_.push_back(make_linked_ptr( 109 content_settings::AbstractProvider* provider =
113 new content_settings::PolicyProvider(this, 110 new content_settings::PolicyProvider(
114 prefs_, 111 this, prefs_, policy_default_provider);
115 policy_default_provider))); 112 content_settings_providers_.push_back(make_linked_ptr(provider));
113
116 if (extension_service) { 114 if (extension_service) {
117 // |extension_service| can be NULL in unit tests. 115 // |extension_service| can be NULL in unit tests.
118 content_settings_providers_.push_back(make_linked_ptr( 116 provider = new content_settings::ExtensionProvider(
119 new content_settings::ExtensionProvider( 117 this,
120 this, 118 extension_service->GetExtensionContentSettingsStore(),
121 extension_service->GetExtensionContentSettingsStore(), 119 is_off_the_record_);
122 is_off_the_record_))); 120 content_settings_providers_.push_back(make_linked_ptr(provider));
123 } 121 }
124 content_settings_providers_.push_back(make_linked_ptr( 122 provider = new content_settings::PrefProvider(
125 new content_settings::PrefProvider(this, prefs_, is_off_the_record_))); 123 this, prefs_, is_off_the_record_);
124 content_settings_providers_.push_back(make_linked_ptr(provider));
126 125
127 pref_change_registrar_.Init(prefs_); 126 pref_change_registrar_.Init(prefs_);
128 pref_change_registrar_.Add(prefs::kBlockThirdPartyCookies, this); 127 pref_change_registrar_.Add(prefs::kBlockThirdPartyCookies, this);
129 } 128 }
130 129
131 // static 130 // static
132 void HostContentSettingsMap::RegisterUserPrefs(PrefService* prefs) { 131 void HostContentSettingsMap::RegisterUserPrefs(PrefService* prefs) {
133 prefs->RegisterBooleanPref(prefs::kBlockThirdPartyCookies, 132 prefs->RegisterBooleanPref(prefs::kBlockThirdPartyCookies,
134 false, 133 false,
135 PrefService::SYNCABLE_PREF); 134 PrefService::SYNCABLE_PREF);
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 } 439 }
441 440
442 { 441 {
443 base::AutoLock auto_lock(lock_); 442 base::AutoLock auto_lock(lock_);
444 block_third_party_cookies_ = block; 443 block_third_party_cookies_ = block;
445 } 444 }
446 445
447 prefs_->SetBoolean(prefs::kBlockThirdPartyCookies, block); 446 prefs_->SetBoolean(prefs::kBlockThirdPartyCookies, block);
448 } 447 }
449 448
449 void HostContentSettingsMap::OnContentSettingChanged(
450 ContentSettingsPattern primary_pattern,
451 ContentSettingsPattern secondary_pattern,
452 ContentSettingsType content_type,
453 std::string resource_identifier) {
454 const ContentSettingsDetails details(primary_pattern,
455 secondary_pattern,
456 content_type,
457 resource_identifier);
458 NotificationService::current()->Notify(
459 chrome::NOTIFICATION_CONTENT_SETTINGS_CHANGED,
460 Source<HostContentSettingsMap>(this),
461 Details<const ContentSettingsDetails>(&details));
462 }
463
450 void HostContentSettingsMap::Observe(int type, 464 void HostContentSettingsMap::Observe(int type,
451 const NotificationSource& source, 465 const NotificationSource& source,
452 const NotificationDetails& details) { 466 const NotificationDetails& details) {
453 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 467 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
454 468
455 if (type == chrome::NOTIFICATION_PREF_CHANGED) { 469 if (type == chrome::NOTIFICATION_PREF_CHANGED) {
456 DCHECK_EQ(prefs_, Source<PrefService>(source).ptr()); 470 DCHECK_EQ(prefs_, Source<PrefService>(source).ptr());
457 if (updating_preferences_) 471 if (updating_preferences_)
458 return; 472 return;
459 473
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_COOKIES, 528 SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_COOKIES,
515 (cookie_behavior == net::StaticCookiePolicy::BLOCK_ALL_COOKIES) ? 529 (cookie_behavior == net::StaticCookiePolicy::BLOCK_ALL_COOKIES) ?
516 CONTENT_SETTING_BLOCK : CONTENT_SETTING_ALLOW); 530 CONTENT_SETTING_BLOCK : CONTENT_SETTING_ALLOW);
517 } 531 }
518 if (!prefs_->HasPrefPath(prefs::kBlockThirdPartyCookies)) { 532 if (!prefs_->HasPrefPath(prefs::kBlockThirdPartyCookies)) {
519 SetBlockThirdPartyCookies(cookie_behavior == 533 SetBlockThirdPartyCookies(cookie_behavior ==
520 net::StaticCookiePolicy::BLOCK_SETTING_THIRD_PARTY_COOKIES); 534 net::StaticCookiePolicy::BLOCK_SETTING_THIRD_PARTY_COOKIES);
521 } 535 }
522 } 536 }
523 } 537 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698