src/objects-inl.h - Issue 7342048: Make sure that canonical NaN is also platform NaN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 7342048: Make sure that canonical NaN is also platform NaN. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: remove whitespace changes Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 7fb46d07c77f14355bd8691a1d8bbdbb1f11b9b3..fdc5102049fcc2fd7b9119c9824218203af77053 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -1621,7 +1621,9 @@ inline double FixedDoubleArray::hole_nan_as_double() {

inline double FixedDoubleArray::canonical_not_the_hole_nan_as_double() {

- return BitCast<double, uint64_t>(kCanonicalNonHoleNanInt64);

+ ASSERT(BitCast<uint64_t>(OS::nan_value()) != kHoleNanInt64);

+ ASSERT((BitCast<uint64_t>(OS::nan_value()) >> 32) != kHoleNanUpper32);

+ return OS::nan_value();

}

« no previous file with comments | « src/objects-debug.cc ('k') | src/v8globals.h » ('j') | no next file with comments »