Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 7342048: Make sure that canonical NaN is also platform NaN. (Closed)

Created:
9 years, 5 months ago by danno
Modified:
9 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fixes build failures from FixedDoubleArray IC patch. BUG=none TEST=windows build bot works Committed: http://code.google.com/p/v8/source/detail?r=8646

Patch Set 1 #

Patch Set 2 : fix nit #

Patch Set 3 : remove whitespace changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/v8globals.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
PTAL. Needed to fix build, which is currently busted.
9 years, 5 months ago (2011-07-13 16:31:23 UTC) #1
Jakob Kummerow
9 years, 5 months ago (2011-07-13 16:35:34 UTC) #2
LGTM.

I haven't verified whether this fixes the build, though.

Powered by Google App Engine
This is Rietveld 408576698