Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/common/pref_store.h

Issue 7342043: Fixed regression: various preferences were not persisted when changed from incognito window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/pref_names.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pref_store.h
diff --git a/chrome/common/pref_store.h b/chrome/common/pref_store.h
index bc74af110b83f3dd602e00a767a2109c8728af62..5e8b2c5964285f1e75f5a97f1baddd7d1194cee6 100644
--- a/chrome/common/pref_store.h
+++ b/chrome/common/pref_store.h
@@ -54,9 +54,9 @@ class PrefStore : public base::RefCounted<PrefStore> {
// Whether the store has completed all asynchronous initialization.
virtual bool IsInitializationComplete() const;
- // Get the value for a given preference |key| and stores it in |result|.
- // |result| is only modified if the return value is READ_OK. Ownership of the
- // |result| value remains with the PrefStore.
+ // Get the value for a given preference |key| and stores it in |*result|.
+ // |*result| is only modified if the return value is READ_OK and if |result|
+ // is not NULL. Ownership of the |*result| value remains with the PrefStore.
virtual ReadResult GetValue(const std::string& key,
const base::Value** result) const = 0;
« no previous file with comments | « chrome/common/pref_names.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698