chrome/common/json_pref_store.cc - Issue 7342043: Fixed regression: various preferences were not persisted when changed from incognito window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/json_pref_store.cc

Issue 7342043: Fixed regression: various preferences were not persisted when changed from incognito window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/json_pref_store.cc

diff --git a/chrome/common/json_pref_store.cc b/chrome/common/json_pref_store.cc

index 5891633cffe115e23d68e888fd9c4b483f810ef5..5dd3cf2c29c37176d26ae52ec21952279933e956 100644

--- a/chrome/common/json_pref_store.cc

+++ b/chrome/common/json_pref_store.cc

@@ -155,7 +155,8 @@ PrefStore::ReadResult JsonPrefStore::GetValue(const std::string& key,

const Value** result) const {

Value* tmp = NULL;

if (prefs_->Get(key, &tmp)) {

- *result = tmp;

+ if (result)

+ *result = tmp;

return READ_OK;

}

return READ_NO_VALUE;

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/pref_names.cc » ('j') | no next file with comments »