chrome/browser/policy/configuration_policy_pref_store.cc - Issue 7342043: Fixed regression: various preferences were not persisted when changed from incognito window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_pref_store.cc

Issue 7342043: Fixed regression: various preferences were not persisted when changed from incognito window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_pref_provider_unittest.cc ('k') | chrome/browser/prefs/incognito_user_pref_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/configuration_policy_pref_store.cc

diff --git a/chrome/browser/policy/configuration_policy_pref_store.cc b/chrome/browser/policy/configuration_policy_pref_store.cc

index cf445473b73d5ace757b3aa55ab5fd991e972bf6..23c454a4426e01cb6610c79bab2168e3acdeb7fc 100644

--- a/chrome/browser/policy/configuration_policy_pref_store.cc

+++ b/chrome/browser/policy/configuration_policy_pref_store.cc

@@ -327,7 +327,8 @@ ConfigurationPolicyPrefKeeper::GetValue(const std::string& key,

if (stored_value->IsType(Value::TYPE_NULL))

return PrefStore::READ_USE_DEFAULT;

- *result = stored_value;

+ if (result)

+ *result = stored_value;

return PrefStore::READ_OK;

}