Issue 7342042: Disentangle printing of stub names and memory allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7342042: Disentangle printing of stub names and memory allocation. (Closed)

Created:
9 years, 5 months ago by Sven Panne

Modified:
9 years, 5 months ago

Reviewers:
Søren Thygesen Gjesse, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Disentangle printing of stub names and memory allocation. Using a C++-style method PrintName (a.k.a. << ;-), things get a lot easier when two unrelated concerns are separated. Stubs don't need a name cache anymore, simpler code while generating the stub name, memory allocation is centralized, etc. Committed: http://code.google.com/p/v8/source/detail?r=8627

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -459 lines)			Patch
M	src/arm/code-stubs-arm.h	View	5 chunks	+5 lines, -33 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	5 chunks	+19 lines, -68 lines	0 comments	Download
M	src/code-stubs.h	View	9 chunks	+14 lines, -46 lines	0 comments	Download
M	src/code-stubs.cc	View	4 chunks	+45 lines, -19 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	5 chunks	+5 lines, -33 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	5 chunks	+17 lines, -63 lines	0 comments	Download
M	src/mips/code-stubs-mips.h	View	5 chunks	+5 lines, -33 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	5 chunks	+19 lines, -68 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	5 chunks	+5 lines, -33 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	5 chunks	+17 lines, -63 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages