Issue 7342026: WebUI: work around a crash triggered by a specific navigation in tabbed options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7342026: WebUI: work around a crash triggered by a specific navigation in tabbed options. (Closed)

Created:
9 years, 5 months ago by Mike Mammarella

Modified:
9 years, 5 months ago

Reviewers:
csilv, commit-bot: I haz the power, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

WebUI: work around a crash triggered by a specific navigation in tabbed options. This does not fix the root cause, which is explained in comment 3 on bug 88986. TEST=pressing the back button after closing the password manager does not crash BUG=88986 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92301

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	chrome/browser/ui/webui/options/password_manager_handler.cc	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

LGTM This seems like a good workaround. Adding James for confirmation since Arv is currently ...

9 years, 5 months ago (2011-07-12 23:59:06 UTC) #2

Change committed as 92301

Expand Messages | Collapse Messages