Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: chrome/browser/resources/options/options_page.js

Issue 7342009: Show a different banner in chrome://settings for extension-controlled settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix stuff Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/options_page.js
diff --git a/chrome/browser/resources/options/options_page.js b/chrome/browser/resources/options/options_page.js
index beaa9999ea1030873751c4975ea9f54edfe8f2e4..e4d14f078e98c1171dd2828ae3f06520cd7df1cf 100644
--- a/chrome/browser/resources/options/options_page.js
+++ b/chrome/browser/resources/options/options_page.js
@@ -21,7 +21,6 @@ cr.define('options', function() {
this.pageDivName = pageDivName;
this.pageDiv = $(this.pageDivName);
this.tab = null;
- this.managed = false;
}
const SUBPAGE_SHEET_COUNT = 2;
@@ -808,16 +807,6 @@ cr.define('options', function() {
initializePage: function() {},
/**
- * Sets managed banner visibility state.
- */
- setManagedBannerVisibility: function(visible) {
- this.managed = visible;
- if (this.visible) {
- this.updateManagedBannerVisibility();
- }
- },
-
- /**
* Updates managed banner visibility state. This function iterates over
* all input fields of a window and if any of these is marked as managed
* it triggers the managed banner to be visible. The banner can be enforced
@@ -827,20 +816,25 @@ cr.define('options', function() {
updateManagedBannerVisibility: function() {
var bannerDiv = $('managed-prefs-banner');
- var hasManaged = this.managed;
- if (!hasManaged) {
- var inputElements = this.pageDiv.querySelectorAll('input');
- for (var i = 0, len = inputElements.length; i < len; i++) {
- if (inputElements[i].managed) {
- hasManaged = true;
- break;
- }
- }
+ var controlledByPolicy = false;
+ var controlledByExtension = false;
+ var inputElements = this.pageDiv.querySelectorAll('input[controlledBy]');
+ for (var i = 0, len = inputElements.length; i < len; i++) {
+ if (inputElements[i].controlledBy == 'policy')
+ controlledByPolicy = true;
+ else if (inputElements[i].controlledBy == 'extension')
+ controlledByExtension = true;
}
- if (hasManaged) {
+ if (controlledByPolicy || controlledByExtension) {
bannerDiv.hidden = false;
- var height = window.getComputedStyle($('managed-prefs-banner')).height;
+ var height = window.getComputedStyle(bannerDiv).height;
$('subpage-backdrop').style.top = height;
+ $('policy-and-extension-managed-prefs-text').hidden =
+ !controlledByPolicy || !controlledByExtension;
+ $('policy-managed-prefs-text').hidden =
+ !controlledByPolicy || controlledByExtension;
+ $('extension-managed-prefs-text').hidden =
+ controlledByPolicy || !controlledByExtension;
} else {
bannerDiv.hidden = true;
$('subpage-backdrop').style.top = '0';

Powered by Google App Engine
This is Rietveld 408576698