Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: chrome/app/generated_resources.grd

Issue 7342009: Show a different banner in chrome://settings for extension-controlled settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix stuff Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 8ee0cc2b944c0c438318a86b5748856c12851ae1..5f441c122ef2ec17338e8df5d60d95ef92ecb4d4 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -7810,20 +7810,30 @@ ls' lab.">
</if>
<if expr="pp_ifdef('chromeos')">
- <message name="IDS_OPTIONS_MANAGED_PREFS" desc="ChromeOS banner displayed in case there are managed options the user won't be able to change.">
- Some settings have been disabled by your IT administrator.
+ <message name="IDS_OPTIONS_PREFS_TERM" desc="ChromeOS term for user settings (plural).">
+ settings
</message>
</if>
<if expr="not pp_ifdef('chromeos') and is_posix">
- <message name="IDS_OPTIONS_MANAGED_PREFS" desc="Mac/Linux banner displayed in case there are managed options the user won't be able to change.">
- Some preferences have been disabled by your IT administrator.
+ <message name="IDS_OPTIONS_PREFS_TERM" desc="Mac/Linux term for user settings (plural).">
+ preferences
</message>
</if>
<if expr="is_win">
- <message name="IDS_OPTIONS_MANAGED_PREFS" desc="Windows banner displayed in case there are managed options the user won't be able to change.">
- Some options have been disabled by your IT administrator.
+ <message name="IDS_OPTIONS_PREFS_TERM" desc="Windows term for user settings (plural).">
+ options
</message>
</if>
+
Joao da Silva 2011/07/13 17:35:17 Nit: trailing whites
Bernhard Bauer 2011/07/13 22:15:12 Where?
Joao da Silva 2011/07/14 09:04:11 Line 7827. I patched this into my working tree and
Bernhard Bauer 2011/07/14 10:15:56 Ah, got it.
+ <message name="IDS_OPTIONS_POLICY_MANAGED_PREFS" desc="Banner displayed in case there are policy-managed options the user won't be able to change.">
+ Some <ph name="IDS_OPTIONS_PREFS_TERM">$1<ex>options</ex></ph> have been disabled by your IT administrator.
Evan Stade 2011/07/13 17:06:04 I don't think this is valid for translations. For
Glen Murphy 2011/07/13 17:23:16 We can also drop the 'IT' - it's meaningless to ma
Bernhard Bauer 2011/07/13 22:15:12 Done.
+ </message>
+ <message name="IDS_OPTIONS_EXTENSION_MANAGED_PREFS" desc="Banner displayed in case there are extension-managed options the user won't be able to change.">
+ Some <ph name="IDS_OPTIONS_PREFS_TERM">$1<ex>options</ex></ph> are being managed by an extension for you.
Evan Stade 2011/07/13 17:06:04 Some options are being controlled by an extension.
Bernhard Bauer 2011/07/13 22:15:12 For proxy settings, the text currently reads "Some
+ </message>
+ <message name="IDS_OPTIONS_POLICY_EXTENSION_MANAGED_PREFS" desc="Banner displayed in case there are policy- and extension-managed options the user won't be able to change.">
+ Some <ph name="IDS_OPTIONS_PREFS_TERM">$1<ex>options</ex></ph> have been disabled by your IT administrator, and some are being managed by an extension for you. Lucky you!
Evan Stade 2011/07/13 17:06:04 Some options have been disabled by your IT adminis
Glen Murphy 2011/07/13 17:23:16 Evan's without the 'IT'.
Bernhard Bauer 2011/07/13 22:15:12 Done.
+ </message>
<!-- Options search page strings. -->
<message name="IDS_OPTIONS_SEARCH_PAGE_TITLE" desc="Title of the settings search page.">
« no previous file with comments | « no previous file | chrome/browser/policy/managed_prefs_banner_base.h » ('j') | chrome/browser/resources/options/options.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698