Show a different banner in chrome://settings for extension-controlled settings.

chrome/browser/resources/options/personal_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   // State variables.
   var syncEnabled = false;
@@ skipping 79 matching lines @@
 
       if (PersonalOptions.disablePasswordManagement()) {
         // Disable the Password Manager in guest mode.
         $('passwords-offersave').disabled = true;
         $('passwords-neversave').disabled = true;
         $('passwords-offersave').value = false;
         $('passwords-neversave').value = true;
         $('manage-passwords').disabled = true;
       } else {
         // Otherwise, follow the preference, which can be toggled at runtime.
         // TODO(joaodasilva): remove the radio controls toggles below, once a

[Bernhard Bauer, 2011/07/13 11:22:16]

Joao, could you take a look whether we should change anything here now?

[Joao da Silva, 2011/07/13 17:35:17]

Yes, see comments below. These temporary fixes should go away once we restore
the enabled/disabled state of the controls when policies are removed.

[Bernhard Bauer, 2011/07/13 22:15:12]

But we do that now (see http://crbug.com/80604).

[Joao da Silva, 2011/07/14 09:04:11]

Very cool! In that case this code can be fixed, I'll prepare a CL for that. Can
you still include the fixes below in this patch, so that a regression isn't
introduced?

[Bernhard Bauer, 2011/07/14 10:15:56]

Sure.

         // generic fix for updateElementState_ in pref_ui.js is available.
         // The problem is that updateElementState_ disables controls when a
         // policy enforces the preference, but doesn't re-enable them when the
         // policy is changed or removed. That's because controls can also be
         // disabled for other reasons (e.g. Guest mode, in this case) and
         // removing the policy doesn't mean the control can be enabled again.
         Preferences.getInstance().addEventListener(
             'profile.password_manager_enabled',
             function(event) {
               var managed = event.value && event.value['managed'];

[Joao da Silva, 2011/07/13 17:35:17]

Replace this line with:
var managed = event.value && event.value['controlledBy'];

[Joao da Silva, 2011/07/14 09:04:11]

The lines affecting the radio controls ('passwords-offersave' and
'passwords-neversave') can be removed too.

[Bernhard Bauer, 2011/07/14 10:15:56]

Done.

[Bernhard Bauer, 2011/07/14 10:15:56]

I try to use |event.value['controlledBy']| to store what part of the pref system
controls the preference (for the banner), and |event.value['disabled']| to store
whether the preference is user-modifiable (to disable the UI element itself). In
theory there might be a difference between those two.

               var value = event.value && event.value['value'] != undefined ?
                   event.value['value'] : event.value;
               $('passwords-offersave').disabled = managed;
               $('passwords-neversave').disabled = managed;
               $('manage-passwords').disabled = managed && !value;
             });
       }
 
       if (PersonalOptions.disableAutofillManagement()) {
         $('autofill-settings').disabled = true;
 
         // Disable and turn off autofill.
         var autofillEnabled = $('autofill-enabled');
         autofillEnabled.disabled = true;
         autofillEnabled.checked = false;
         cr.dispatchSimpleEvent(autofillEnabled, 'change');
       } else {
         Preferences.getInstance().addEventListener(
             'autofill.enabled',
             function(event) {
               var managed = event.value && event.value['managed'];

[Joao da Silva, 2011/07/13 17:35:17]

Same change on this line too.

[Bernhard Bauer, 2011/07/14 10:15:56]

Done.

               var value = event.value && event.value['value'] != undefined ?
                   event.value['value'] : event.value;
               $('autofill-settings').disabled = managed && !value;
             });
       }
     },
 
     setSyncEnabled_: function(enabled) {
       this.syncEnabled = enabled;
     },
@@ skipping 128 matching lines @@
       PersonalOptions.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     PersonalOptions: PersonalOptions
   };
 
 });
+

[Evan Stade, 2011/07/13 17:06:04]

?

[Bernhard Bauer, 2011/07/13 22:15:12]

That was a whitespace change to include this file in the CL (so Joao can comment
on it). I'll remove it before committing.