Issue 7341001: Rollback r90712 (which was a partial rollback of r90660) to re-enable building

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7341001: Rollback r90712 (which was a partial rollback of r90660) to re-enable building (Closed)

Created:
9 years, 5 months ago by Ami GONE FROM CHROMIUM

Modified:
9 years, 5 months ago

Reviewers:
brettw, Ryan Sleevi

CC:
chromium-reviews, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Rollback r90712 (which was a partial rollback of r90660) to re-enable building PPAPI examples on windows. BUG=54005 TEST=not so much, since the trybots don't build all. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92168

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	ppapi/ppapi_tests.gypi	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

Brett: please review + OWNERS. Darin/Ryan: FYI.

9 years, 5 months ago (2011-07-12 00:06:20 UTC) #1

Ryan Sleevi

LGTM - but one typo introduced in fixing my original typo. Example is http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/chrome_tests.gypi&l=3972 http://codereview.chromium.org/7341001/diff/1/ppapi/ppapi_tests.gypi ...

9 years, 5 months ago (2011-07-12 00:16:26 UTC) #2

Ami GONE FROM CHROMIUM

http://codereview.chromium.org/7341001/diff/1/ppapi/ppapi_tests.gypi File ppapi/ppapi_tests.gypi (right): http://codereview.chromium.org/7341001/diff/1/ppapi/ppapi_tests.gypi#newcode203 ppapi/ppapi_tests.gypi:203: 'suppress_wildcards': 1, On 2011/07/12 00:16:26, Ryan Sleevi wrote: > ...

9 years, 5 months ago (2011-07-12 00:23:59 UTC) #3

LGTM

Expand Messages | Collapse Messages