Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 7337007: Introduce a field trial for Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix onchange handling Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 const OptionsPage = options.OptionsPage; 6 const OptionsPage = options.OptionsPage;
7 const ArrayDataModel = cr.ui.ArrayDataModel; 7 const ArrayDataModel = cr.ui.ArrayDataModel;
8 8
9 // 9 //
10 // BrowserOptions class 10 // BrowserOptions class
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 if (self.instantConfirmDialogShown_) 76 if (self.instantConfirmDialogShown_)
77 chrome.send('enableInstant'); 77 chrome.send('enableInstant');
78 else 78 else
79 OptionsPage.navigateToPage('instantConfirm'); 79 OptionsPage.navigateToPage('instantConfirm');
80 } else { 80 } else {
81 chrome.send('disableInstant'); 81 chrome.send('disableInstant');
82 } 82 }
83 return true; 83 return true;
84 }; 84 };
85 85
86 $('instantFieldTrialCheckbox').onchange = function(event) {
Sheridan Rawlins 2011/07/26 07:07:15 Follow style of others in this file: use addEventL
sreeram 2011/07/26 07:36:10 Done.
87 this.checked = true;
88 chrome.send('disableInstant');
89 }
90
86 Preferences.getInstance().addEventListener('instant.confirm_dialog_shown', 91 Preferences.getInstance().addEventListener('instant.confirm_dialog_shown',
87 this.onInstantConfirmDialogShownChanged_.bind(this)); 92 this.onInstantConfirmDialogShownChanged_.bind(this));
88 93
94 Preferences.getInstance().addEventListener('instant.enabled',
95 this.onInstantEnabledChanged_.bind(this));
96
89 var homepageField = $('homepageURL'); 97 var homepageField = $('homepageURL');
90 $('homepageUseNTPButton').onchange = 98 $('homepageUseNTPButton').onchange =
91 this.handleHomepageUseNTPButtonChange_.bind(this); 99 this.handleHomepageUseNTPButtonChange_.bind(this);
92 $('homepageUseURLButton').onchange = 100 $('homepageUseURLButton').onchange =
93 this.handleHomepageUseURLButtonChange_.bind(this); 101 this.handleHomepageUseURLButtonChange_.bind(this);
94 var homepageChangeHandler = this.handleHomepageURLChange_.bind(this); 102 var homepageChangeHandler = this.handleHomepageURLChange_.bind(this);
95 homepageField.addEventListener('change', homepageChangeHandler); 103 homepageField.addEventListener('change', homepageChangeHandler);
96 homepageField.addEventListener('input', homepageChangeHandler); 104 homepageField.addEventListener('input', homepageChangeHandler);
97 homepageField.addEventListener('focus', function(event) { 105 homepageField.addEventListener('focus', function(event) {
98 self.autocompleteList_.attachToInput(homepageField); 106 self.autocompleteList_.attachToInput(homepageField);
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 * Called when the value of the instant.confirm_dialog_shown preference 170 * Called when the value of the instant.confirm_dialog_shown preference
163 * changes. Cache this value. 171 * changes. Cache this value.
164 * @param {Event} event Change event. 172 * @param {Event} event Change event.
165 * @private 173 * @private
166 */ 174 */
167 onInstantConfirmDialogShownChanged_: function(event) { 175 onInstantConfirmDialogShownChanged_: function(event) {
168 this.instantConfirmDialogShown_ = event.value['value']; 176 this.instantConfirmDialogShown_ = event.value['value'];
169 }, 177 },
170 178
171 /** 179 /**
180 * Called when the value of the instant.enabled preference changes. Request
181 * the state of the Instant field trial experiment.
182 * @param {Event} event Change event.
183 * @private
184 */
185 onInstantEnabledChanged_: function(event) {
186 chrome.send('getInstantFieldTrialStatus');
187 },
188
189 /**
190 * Called to set the Instant field trial status.
191 * @param {boolean} enabled If true, the experiment is enabled.
192 * @private
193 */
194 setInstantFieldTrialStatus_: function(enabled) {
195 $('instantEnabledCheckbox').hidden = enabled;
196 $('instantFieldTrialCheckbox').hidden = !enabled;
197 },
198
199 /**
172 * Update the Default Browsers section based on the current state. 200 * Update the Default Browsers section based on the current state.
173 * @param {string} statusString Description of the current default state. 201 * @param {string} statusString Description of the current default state.
174 * @param {boolean} isDefault Whether or not the browser is currently 202 * @param {boolean} isDefault Whether or not the browser is currently
175 * default. 203 * default.
176 * @param {boolean} canBeDefault Whether or not the browser can be default. 204 * @param {boolean} canBeDefault Whether or not the browser can be default.
177 * @private 205 * @private
178 */ 206 */
179 updateDefaultBrowserState_: function(statusString, isDefault, 207 updateDefaultBrowserState_: function(statusString, isDefault,
180 canBeDefault) { 208 canBeDefault) {
181 var label = $('defaultBrowserState'); 209 var label = $('defaultBrowserState');
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 }; 510 };
483 511
484 BrowserOptions.updateStartupPages = function(pages) { 512 BrowserOptions.updateStartupPages = function(pages) {
485 BrowserOptions.getInstance().updateStartupPages_(pages); 513 BrowserOptions.getInstance().updateStartupPages_(pages);
486 }; 514 };
487 515
488 BrowserOptions.updateAutocompleteSuggestions = function(suggestions) { 516 BrowserOptions.updateAutocompleteSuggestions = function(suggestions) {
489 BrowserOptions.getInstance().updateAutocompleteSuggestions_(suggestions); 517 BrowserOptions.getInstance().updateAutocompleteSuggestions_(suggestions);
490 }; 518 };
491 519
520 BrowserOptions.setInstantFieldTrialStatus = function(enabled) {
521 BrowserOptions.getInstance().setInstantFieldTrialStatus_(enabled);
522 };
523
492 // Export 524 // Export
493 return { 525 return {
494 BrowserOptions: BrowserOptions 526 BrowserOptions: BrowserOptions
495 }; 527 };
496 528
497 }); 529 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698