Issue 7335002: Allow JSObject::PreventExtensions to work for arguments objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7335002: Allow JSObject::PreventExtensions to work for arguments objects. (Closed)

Created:
9 years, 5 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 5 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Allow JSObject::PreventExtensions to work for arguments objects. R=karlklose@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8587

Patch Set 1 #

Total comments: 3

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -11 lines)			Patch
	M	src/objects.cc	View		1 chunk	+10 lines, -11 lines	0 comments	Download
	A	test/mjsunit/regress/regress-88858.js	View		1 chunk	+65 lines, -0 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

9 years, 5 months ago (2011-07-11 06:45:52 UTC) #2

LGTM.

http://codereview.chromium.org/7335002/diff/1/test/mjsunit/regress/regress-88...
File test/mjsunit/regress/regress-88858.js (right):

http://codereview.chromium.org/7335002/diff/1/test/mjsunit/regress/regress-88...
test/mjsunit/regress/regress-88858.js:54: function __noSuchMethod__( ) {
Remove space.

http://codereview.chromium.org/7335002/diff/1/test/mjsunit/regress/regress-88...
test/mjsunit/regress/regress-88858.js:59: f.p = function() {};
Add space.

http://codereview.chromium.org/7335002/diff/1/test/mjsunit/regress/regress-88...
test/mjsunit/regress/regress-88858.js:63: } catch(exc2) {}
Add space.

Expand Messages | Collapse Messages