second attempt at correcting fopen (hangs when trying to read from a dir)

second attempt at correcting fopen (hangs when trying to read from a dir)

Committed: http://code.google.com/p/v8/source/detail?r=8611

[Yang, 2011-07-11 14:30:42]

Hi Sven,

entspricht das in etwa deiner Vorstellung? :)

Yang

[Yang, 2011-07-11 14:37:14]

My bad. Should have written in English.

Changed v8::internal::FOpen for POSIX according to what we discussed.

[Sven Panne, 2011-07-11 15:02:41]

http://codereview.chromium.org/7334010/diff/1/src/platform-posix.cc
File src/platform-posix.cc (right):

http://codereview.chromium.org/7334010/diff/1/src/platform-posix.cc#newcode137
src/platform-posix.cc:137: if (fstat(fileno(file), &file_stat) == 0 &&
(file_stat.st_mode & S_IFREG))
Omit braces only for one-liners.

Do not use ints as boolean values.

Introduce an explaining variable is_regular_file
(http://www.refactoring.com/catalog/introduceExplainingVariable.html).

Guard clauses are easier to read than nested conditionals
(http://www.refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html).

[Yang, 2011-07-11 15:16:46]

how about this?

[Yang, 2011-07-11 15:18:06]

minor change

[Sven Panne, 2011-07-11 15:19:20]

LGTM

[i.maidanski, 2017-08-03 09:40:26]

On 2011/07/11 15:16:46, Yang wrote:
> how about this?

I've found a handle leak in your commit: fclose() is needed when fstat fails
(see my comment in
https://github.com/v8/v8/commit/216a3935c9490ae60f7f80f7dd32c2422e06a72c).

Could you make a fix?