Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: src/deoptimizer.cc

Issue 7334005: Fix heap corruption and memory leakage in inspection of optimized frames. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1427 matching lines...) Expand 10 before | Expand all | Expand 10 after
1438 UNREACHABLE(); 1438 UNREACHABLE();
1439 } 1439 }
1440 1440
1441 1441
1442 DeoptimizedFrameInfo::DeoptimizedFrameInfo( 1442 DeoptimizedFrameInfo::DeoptimizedFrameInfo(
1443 Deoptimizer* deoptimizer, int frame_index) { 1443 Deoptimizer* deoptimizer, int frame_index) {
1444 FrameDescription* output_frame = deoptimizer->output_[frame_index]; 1444 FrameDescription* output_frame = deoptimizer->output_[frame_index];
1445 SetFunction(output_frame->GetFunction()); 1445 SetFunction(output_frame->GetFunction());
1446 expression_count_ = output_frame->GetExpressionCount(deoptimizer); 1446 expression_count_ = output_frame->GetExpressionCount(deoptimizer);
1447 parameters_count_ = output_frame->ComputeParametersCount(); 1447 parameters_count_ = output_frame->ComputeParametersCount();
1448 parameters_ = new Object*[expression_count_]; 1448 parameters_ = new Object*[parameters_count_];
1449 for (int i = 0; i < parameters_count_; i++) { 1449 for (int i = 0; i < parameters_count_; i++) {
1450 SetParameter(i, output_frame->GetParameter(deoptimizer, i)); 1450 SetParameter(i, output_frame->GetParameter(deoptimizer, i));
1451 } 1451 }
1452 expression_stack_ = new Object*[expression_count_]; 1452 expression_stack_ = new Object*[expression_count_];
1453 for (int i = 0; i < expression_count_; i++) { 1453 for (int i = 0; i < expression_count_; i++) {
1454 SetExpression(i, output_frame->GetExpression(deoptimizer, i)); 1454 SetExpression(i, output_frame->GetExpression(deoptimizer, i));
1455 } 1455 }
1456 } 1456 }
1457 1457
1458 1458
1459 DeoptimizedFrameInfo::~DeoptimizedFrameInfo() { 1459 DeoptimizedFrameInfo::~DeoptimizedFrameInfo() {
1460 delete expression_stack_; 1460 delete[] expression_stack_;
1461 delete[] parameters_;
1461 } 1462 }
1462 1463
1463 void DeoptimizedFrameInfo::Iterate(ObjectVisitor* v) { 1464 void DeoptimizedFrameInfo::Iterate(ObjectVisitor* v) {
1464 v->VisitPointer(reinterpret_cast<Object**>(&function_)); 1465 v->VisitPointer(reinterpret_cast<Object**>(&function_));
1465 v->VisitPointers(parameters_, parameters_ + parameters_count_); 1466 v->VisitPointers(parameters_, parameters_ + parameters_count_);
1466 v->VisitPointers(expression_stack_, expression_stack_ + expression_count_); 1467 v->VisitPointers(expression_stack_, expression_stack_ + expression_count_);
1467 } 1468 }
1468 1469
1469 1470
1470 } } // namespace v8::internal 1471 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698