Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 7332001: Removed useless implementations of GetName and Print for code stubs, the common (Closed)

Created:
9 years, 5 months ago by Sven Panne
Modified:
9 years, 5 months ago
Reviewers:
Rico, danno
CC:
v8-dev
Visibility:
Public.

Description

Removed useless implementations of GetName and Print for code stubs, the common super-class handles the most common case already. Committed: http://code.google.com/p/v8/source/detail?r=8576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -151 lines) Patch
M src/arm/code-stubs-arm.h View 7 chunks +2 lines, -21 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/code-stubs.h View 20 chunks +4 lines, -56 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 4 chunks +2 lines, -17 lines 0 comments Download
M src/mips/code-stubs-mips.h View 7 chunks +2 lines, -27 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.h View 4 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
9 years, 5 months ago (2011-07-08 09:33:35 UTC) #1
Rico
LGTM
9 years, 5 months ago (2011-07-08 09:39:52 UTC) #2
danno
9 years, 5 months ago (2011-07-08 09:49:54 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698