fix for 27454 - Fade out close button state on mouse exit

fix for 27454 - Fade out close button state on mouse exit

Changed TabView.xib to make the close button have a layer backing it's view.

BUG=27454
TEST=Create some tabs. Move the cursor over the close button for the tabs, and then out. Watch them fade.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92318

[dmac, 2011-07-11 17:22:37]

Since Mr. Bonventre has left the building, would you mind taking a look please?
My contribution to the UI fixit.

[Miranda Callahan, 2011-07-12 13:44:35]

+rsesek

Hey dmac, sure -- LGTM with the question about the comment looking different
from the code, but I think you should get rsesek to take a look here as well; I
haven't looked at Mac animation code in many moons, and am a bit rusty.

http://codereview.chromium.org/7331042/diff/1/chrome/browser/ui/cocoa/hover_c...
File chrome/browser/ui/cocoa/hover_close_button.mm (right):

http://codereview.chromium.org/7331042/diff/1/chrome/browser/ui/cocoa/hover_c...
chrome/browser/ui/cocoa/hover_close_button.mm:136: // and centered vertically.
Is it really 8 pixels from the left edge? I don't read that in the
constraint...?

[dmac, 2011-07-12 17:55:07]

On 2011/07/12 13:44:35, Miranda Callahan wrote:
> +rsesek
> 
> Hey dmac, sure -- LGTM with the question about the comment looking different
> from the code, but I think you should get rsesek to take a look here as well;
I
> haven't looked at Mac animation code in many moons, and am a bit rusty.
> 
>
http://codereview.chromium.org/7331042/diff/1/chrome/browser/ui/cocoa/hover_c...
> File chrome/browser/ui/cocoa/hover_close_button.mm (right):
> 
>
http://codereview.chromium.org/7331042/diff/1/chrome/browser/ui/cocoa/hover_c...
> chrome/browser/ui/cocoa/hover_close_button.mm:136: // and centered vertically.
> Is it really 8 pixels from the left edge? I don't read that in the
> constraint...?

Good catch miranda. Hate it when comments bitrot that fast ;-) Fixed... also
added a scoped graphics context saver.

rsesek, would you mind giving it a look see? Running it through the mac trybot
now.

[Robert Sesek, 2011-07-12 18:11:40]

Please also update the CL description to enumerate the XIB changes.

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
File chrome/browser/ui/cocoa/hover_button.h (right):

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_button.h:26: scoped_nsobject<CrTrackingArea>
trackingArea_;
You may want to use ScopedCrTracingArea.

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_button.h:29: @property (nonatomic) HoverState
hoverState;
nit: no space before (

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
File chrome/browser/ui/cocoa/hover_close_button.h (right):

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.h:13: // the popup blocker, download
bar, info bar and tabs.
nit: not used by the popup blocker anymore, and it hasn't been for some time

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
File chrome/browser/ui/cocoa/hover_close_button.mm (right):

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.mm:116: if (state != kHoverStateNone)
{
optional nit: no braces for single-line if's

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.mm:151: [hoverNoneLayer_.get()
setFrame:viewLayer.frame];
(3x) why .get() here and not elsewhere?

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.mm:224: return [imageRep CGImage];
Memory management here may warrant a function-level comment.

[dmac, 2011-07-12 19:04:42]

Thanks rsesek. PTAL.

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
File chrome/browser/ui/cocoa/hover_button.h (right):

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_button.h:26: scoped_nsobject<CrTrackingArea>
trackingArea_;
On 2011/07/12 18:11:40, rsesek wrote:
> You may want to use ScopedCrTracingArea.

Done.

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_button.h:29: @property (nonatomic) HoverState
hoverState;
On 2011/07/12 18:11:40, rsesek wrote:
> nit: no space before (

Done.

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
File chrome/browser/ui/cocoa/hover_close_button.h (right):

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.h:13: // the popup blocker, download
bar, info bar and tabs.
On 2011/07/12 18:11:40, rsesek wrote:
> nit: not used by the popup blocker anymore, and it hasn't been for some time

Done.

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
File chrome/browser/ui/cocoa/hover_close_button.mm (right):

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.mm:116: if (state != kHoverStateNone)
{
On 2011/07/12 18:11:40, rsesek wrote:
> optional nit: no braces for single-line if's

ignored... I hate that braces are optional ;-)

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.mm:151: [hoverNoneLayer_.get()
setFrame:viewLayer.frame];
On 2011/07/12 18:11:40, rsesek wrote:
> (3x) why .get() here and not elsewhere?

commented.

http://codereview.chromium.org/7331042/diff/4001/chrome/browser/ui/cocoa/hove...
chrome/browser/ui/cocoa/hover_close_button.mm:224: return [imageRep CGImage];
On 2011/07/12 18:11:40, rsesek wrote:
> Memory management here may warrant a function-level comment.

Done.

[Robert Sesek, 2011-07-12 19:37:27]

LGTM if you update the CL description.