Issue 7331037: Prepare push to trunk. We are now working on version 3.4.12.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7331037: Prepare push to trunk. We are now working on version 3.4.12. (Closed)

Created:
9 years, 5 months ago by Søren Thygesen Gjesse

Modified:
9 years, 5 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. We are now working on version 3.4.12. R=ricow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8591

Patch Set 2 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	ChangeLog	View	1	2 chunks	+18 lines, -1 line	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/7331037/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/7331037/diff/1/ChangeLog#newcode13 ChangeLog:13: Allow JSObject::PreventExtensions to work for arguments objects. Allow ...

9 years, 5 months ago (2011-07-11 11:08:48 UTC) #2

Søren Thygesen Gjesse

9 years, 5 months ago (2011-07-11 11:10:20 UTC) #3

http://codereview.chromium.org/7331037/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7331037/diff/1/ChangeLog#newcode13
ChangeLog:13: Allow JSObject::PreventExtensions to work for arguments objects.
On 2011/07/11 11:08:51, Rico wrote:
> Allow ->Allowed

Done.

Expand Messages | Collapse Messages

Issue 7331037: Prepare push to trunk. We are now working on version 3.4.12. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages